Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 212663004: Fix a problem that video does not show up in Chrome Shell. (Closed)

Created:
6 years, 9 months ago by Sungmann Cho
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix a problem that video does not show up in Chrome Shell. Chrome Shell shows a black screen when we play a video. Some parts of the fullscreen video feature was changed recently, but the changes were applied to only Content Shell. Please refer to https://codereview.chromium.org/182493003. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 3 chunks +21 lines, -1 line 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 41 (0 generated)
Sungmann Cho
Please take a look. Thanks.
6 years, 9 months ago (2014-03-26 12:08:29 UTC) #1
qinmin
lgtm
6 years, 9 months ago (2014-03-26 17:07:41 UTC) #2
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-27 20:45:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
6 years, 9 months ago (2014-03-27 20:47:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 21:17:00 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58072
6 years, 9 months ago (2014-03-27 21:17:01 UTC) #6
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-27 23:47:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
6 years, 9 months ago (2014-03-27 23:48:17 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 00:12:40 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58149
6 years, 9 months ago (2014-03-28 00:12:41 UTC) #10
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-28 02:00:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
6 years, 9 months ago (2014-03-28 02:02:13 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 02:56:01 UTC) #13
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58181
6 years, 9 months ago (2014-03-28 02:56:02 UTC) #14
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-28 04:07:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
6 years, 9 months ago (2014-03-28 04:09:00 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 04:44:15 UTC) #17
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58198
6 years, 9 months ago (2014-03-28 04:44:15 UTC) #18
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-28 05:31:25 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
6 years, 9 months ago (2014-03-28 05:32:23 UTC) #20
Sungmann Cho
The CQ bit was unchecked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-28 05:47:00 UTC) #21
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-28 06:35:21 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
6 years, 9 months ago (2014-03-28 06:35:35 UTC) #23
Sungmann Cho
The CQ bit was unchecked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-28 06:53:41 UTC) #24
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-28 07:27:04 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
6 years, 9 months ago (2014-03-28 07:28:28 UTC) #26
Sungmann Cho
The CQ bit was unchecked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-28 07:54:46 UTC) #27
Sungmann Cho
Sorry for making a mess. :( But why chromium_presubmit fails?
6 years, 9 months ago (2014-03-28 07:56:35 UTC) #28
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-28 10:29:44 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
6 years, 9 months ago (2014-03-28 10:31:09 UTC) #30
Sungmann Cho
The CQ bit was unchecked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-28 10:44:47 UTC) #31
Sungmann Cho
Oops. I missed LGTM from the OWNER. I'm so sorry to bother you. :(
6 years, 9 months ago (2014-03-28 11:03:13 UTC) #32
Sungmann Cho
+Ted C Please take a look. Thanks.
6 years, 9 months ago (2014-03-28 18:36:10 UTC) #33
Ted C
lgtm
6 years, 9 months ago (2014-03-28 18:39:28 UTC) #34
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-28 18:42:13 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
6 years, 9 months ago (2014-03-28 18:45:47 UTC) #36
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 23:44:40 UTC) #37
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-28 23:44:41 UTC) #38
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-29 00:01:54 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
6 years, 9 months ago (2014-03-29 00:06:41 UTC) #40
commit-bot: I haz the power
6 years, 9 months ago (2014-03-29 00:11:22 UTC) #41
Message was sent while issue was closed.
Change committed as 260315

Powered by Google App Engine
This is Rietveld 408576698