|
|
Created:
6 years, 9 months ago by Sungmann Cho Modified:
6 years, 9 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionFix a problem that video does not show up in Chrome Shell.
Chrome Shell shows a black screen when we play a video.
Some parts of the fullscreen video feature was changed recently, but the changes were applied to only Content Shell.
Please refer to https://codereview.chromium.org/182493003.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260315
Patch Set 1 #
Messages
Total messages: 41 (0 generated)
Please take a look. Thanks.
lgtm
The CQ bit was checked by sungmann.cho@navercorp.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
The CQ bit was checked by sungmann.cho@navercorp.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
The CQ bit was checked by sungmann.cho@navercorp.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
The CQ bit was checked by sungmann.cho@navercorp.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
The CQ bit was checked by sungmann.cho@navercorp.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
The CQ bit was unchecked by sungmann.cho@navercorp.com
The CQ bit was checked by sungmann.cho@navercorp.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
The CQ bit was unchecked by sungmann.cho@navercorp.com
The CQ bit was checked by sungmann.cho@navercorp.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
The CQ bit was unchecked by sungmann.cho@navercorp.com
Sorry for making a mess. :( But why chromium_presubmit fails?
The CQ bit was checked by sungmann.cho@navercorp.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
The CQ bit was unchecked by sungmann.cho@navercorp.com
Oops. I missed LGTM from the OWNER. I'm so sorry to bother you. :(
+Ted C Please take a look. Thanks.
lgtm
The CQ bit was checked by sungmann.cho@navercorp.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by sungmann.cho@navercorp.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/212663004/1
Message was sent while issue was closed.
Change committed as 260315 |