Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 182493003: enable subtitle support and the new fullscreen video (Closed)

Created:
6 years, 10 months ago by qinmin
Modified:
6 years, 9 months ago
Reviewers:
Ted C, Yaron, trchen, Jói, boliu
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

enable subtitle support and the new fullscreen video This CL enables the subtitle and new fullscreen video for chrome. The new fullscreen mode has been in testing for a while, this Cl will enable this new fullscreen mode. BUG=262945 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255500

Patch Set 1 #

Patch Set 2 : don't enable fullscreen subtitle for webview #

Total comments: 2

Patch Set 3 : fix component build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/android/content_video_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/ShellManager.java View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
qinmin
PTAL
6 years, 10 months ago (2014-02-27 00:55:35 UTC) #1
Ted C
lgtm
6 years, 10 months ago (2014-02-27 00:59:52 UTC) #2
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 10 months ago (2014-02-27 01:09:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/182493003/1
6 years, 10 months ago (2014-02-27 01:11:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-27 06:51:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 10 months ago (2014-02-27 06:51:24 UTC) #6
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 10 months ago (2014-02-27 07:19:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/182493003/1
6 years, 10 months ago (2014-02-27 07:19:34 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 17:47:38 UTC) #9
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 9 months ago (2014-02-27 17:47:39 UTC) #10
qinmin
+joi for content_switches.cc +boliu for webview. Since webview does not support this mode yet, turn ...
6 years, 9 months ago (2014-02-28 23:09:52 UTC) #11
boliu
lgtm
6 years, 9 months ago (2014-02-28 23:12:28 UTC) #12
Jói
//content/public LGTM.
6 years, 9 months ago (2014-03-03 12:51:57 UTC) #13
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 9 months ago (2014-03-06 16:24:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/182493003/30008
6 years, 9 months ago (2014-03-06 16:24:52 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 17:39:37 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=276400
6 years, 9 months ago (2014-03-06 17:39:38 UTC) #17
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 9 months ago (2014-03-06 18:00:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/182493003/30008
6 years, 9 months ago (2014-03-06 18:02:23 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 19:39:49 UTC) #20
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=121289
6 years, 9 months ago (2014-03-06 19:39:50 UTC) #21
boliu
android_clang_dbg does component build https://codereview.chromium.org/182493003/diff/30008/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/182493003/diff/30008/content/public/common/content_switches.h#newcode148 content/public/common/content_switches.h:148: extern const char kDisableOverlayFullscreenVideoSubtitle[]; need ...
6 years, 9 months ago (2014-03-06 19:42:52 UTC) #22
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 9 months ago (2014-03-06 20:25:59 UTC) #23
qinmin
https://codereview.chromium.org/182493003/diff/30008/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/182493003/diff/30008/content/public/common/content_switches.h#newcode148 content/public/common/content_switches.h:148: extern const char kDisableOverlayFullscreenVideoSubtitle[]; On 2014/03/06 19:42:53, boliu wrote: ...
6 years, 9 months ago (2014-03-06 20:26:32 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/182493003/50001
6 years, 9 months ago (2014-03-06 20:52:46 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/182493003/50001
6 years, 9 months ago (2014-03-06 21:39:53 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/182493003/50001
6 years, 9 months ago (2014-03-06 22:16:11 UTC) #27
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 02:35:42 UTC) #28
Message was sent while issue was closed. 
Change committed as 255500

Powered by Google App Engine
This is Rietveld 408576698