Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2126603003: [builtins] Migrate ArrayBufferPrototypeByteLength to C++. (Closed)

Created:
4 years, 5 months ago by Franzi
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate ArrayBufferPrototypeByteLength to C++. Working on eliminating the use of ClassOf(). This function was checking IS_ARRAYBUFFER. BUG= Committed: https://crrev.com/efcd385ddf4046423d5c8c2b8b8b6e33869c946f Cr-Commit-Position: refs/heads/master@{#37565}

Patch Set 1 #

Patch Set 2 : Delete runtime function ArrayBufferGetByteLength #

Patch Set 3 : Keep intrinsic for performance #

Patch Set 4 : Add comment with ES6 section #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M src/bootstrapper.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/js/arraybuffer.js View 2 2 chunks +0 lines, -11 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Franzi
Hi Benedikt, I got started with remove ClassOf() usages. Here's ArrayBuffer.prototype.byteLength as a builtin function ...
4 years, 5 months ago (2016-07-06 11:25:07 UTC) #3
Benedikt Meurer
LGTM, thanks.
4 years, 5 months ago (2016-07-06 17:49:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126603003/60001
4 years, 5 months ago (2016-07-06 18:54:50 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-06 19:23:57 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 19:25:40 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/efcd385ddf4046423d5c8c2b8b8b6e33869c946f
Cr-Commit-Position: refs/heads/master@{#37565}

Powered by Google App Engine
This is Rietveld 408576698