Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2123263002: [builtins] Migrate SharedArrayBuffer.byteLength to C++. (Closed)

Created:
4 years, 5 months ago by Franzi
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@ArrayBufferGetByteLen
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate SharedArrayBuffer.byteLength to C++. Drive-by-fix: hydrogen code does not blindly return the byteLength offset, instead it executes what is defined in the byteLength getter. BUG= Committed: https://crrev.com/2f36ee71768a880a30a75caf4881ff27f71a26d2 Cr-Commit-Position: refs/heads/master@{#37595}

Patch Set 1 #

Patch Set 2 : Checking for failing test #

Patch Set 3 : Fix error message for wrong receiver #

Patch Set 4 : Change comment #

Patch Set 5 : ByteLength on ArrayBuffer is a property on protoype #

Patch Set 6 : Delete broken hydrogen code #

Patch Set 7 : Pass call and id as params instead of doing strcmp on name #

Patch Set 8 : Minor typo fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -186 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/accessors.cc View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 2 3 4 5 6 7 6 chunks +14 lines, -9 lines 0 comments Download
M src/builtins.h View 1 2 3 4 5 6 7 1 chunk +143 lines, -141 lines 0 comments Download
M src/builtins.cc View 1 2 2 chunks +22 lines, -0 lines 0 comments Download
D src/js/harmony-sharedarraybuffer.js View 1 chunk +0 lines, -31 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/harmony/sharedarraybuffer.js View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Franzi
Hi Benedikt, Here's byteLength as C++ builtin for SharedArrayBuffers. We probably want JS_SHARED_ARRAY_BUFFER_TYPE at some ...
4 years, 5 months ago (2016-07-07 14:38:32 UTC) #6
Benedikt Meurer
Very nice. LGTM, thanks.
4 years, 5 months ago (2016-07-07 19:00:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123263002/140001
4 years, 5 months ago (2016-07-07 19:11:35 UTC) #9
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 5 months ago (2016-07-07 19:42:22 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 19:44:34 UTC) #13
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/2f36ee71768a880a30a75caf4881ff27f71a26d2
Cr-Commit-Position: refs/heads/master@{#37595}

Powered by Google App Engine
This is Rietveld 408576698