Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Unified Diff: ui/message_center/views/notification_view.cc

Issue 2126433002: Use container::back() and container::pop_back() in ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pre-increment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/popup_timers_controller.cc ('k') | ui/ozone/platform/drm/gpu/drm_device.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/views/notification_view.cc
diff --git a/ui/message_center/views/notification_view.cc b/ui/message_center/views/notification_view.cc
index 4e6246c675276a98ff6ac714740a3f800e20b9c9..b37c8a995c1c82c2c0aaeb824814fab4fd5e9f42 100644
--- a/ui/message_center/views/notification_view.cc
+++ b/ui/message_center/views/notification_view.cc
@@ -95,7 +95,7 @@ std::unique_ptr<views::Border> MakeSeparatorBorder(int top,
// message next to each other within a single column.
class ItemView : public views::View {
public:
- ItemView(const message_center::NotificationItem& item);
+ explicit ItemView(const message_center::NotificationItem& item);
~ItemView() override;
// Overridden from views::View:
@@ -435,7 +435,7 @@ void NotificationView::CreateOrUpdateMessageView(
message_view_->SetText(text);
}
- message_view_->SetVisible(!notification.items().size());
+ message_view_->SetVisible(notification.items().empty());
}
base::string16 NotificationView::FormatContextMessage(
@@ -545,7 +545,7 @@ void NotificationView::CreateOrUpdateProgressBarView(
if (!is_indeterminate)
progress_bar_view_->SetValue(notification.progress() / 100.0);
- progress_bar_view_->SetVisible(!notification.items().size());
+ progress_bar_view_->SetVisible(notification.items().empty());
}
void NotificationView::CreateOrUpdateListItemViews(
« no previous file with comments | « ui/message_center/popup_timers_controller.cc ('k') | ui/ozone/platform/drm/gpu/drm_device.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698