ui/message_center/popup_timers_controller.cc - Issue 2126433002: Use container::back() and container::pop_back() in ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/popup_timers_controller.cc

Issue 2126433002: Use container::back() and container::pop_back() in ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pre-increment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/message_center/popup_timers_controller.cc

diff --git a/ui/message_center/popup_timers_controller.cc b/ui/message_center/popup_timers_controller.cc

index 2da3e2705e2f242d3a83085c03091c0f81e67639..c50d7e60dfb044f8d4e5666959f1454c51e5529b 100644

--- a/ui/message_center/popup_timers_controller.cc

+++ b/ui/message_center/popup_timers_controller.cc

@@ -96,7 +96,7 @@ void PopupTimersController::OnNotificationUpdated(const std::string& id) {

NotificationList::PopupNotifications popup_notifications =

message_center_->GetPopupNotifications();

- if (!popup_notifications.size()) {

+ if (popup_notifications.empty()) {

CancelAll();

return;

}

« no previous file with comments | « ui/message_center/notification_list_unittest.cc ('k') | ui/message_center/views/notification_view.cc » ('j') | no next file with comments »