Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2126433002: Use container::back() and container::pop_back() in ui/ (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, ozone-reviews_chromium.org, Peter Beverloo, yusukes+watch_chromium.org, tdresser+watch_chromium.org, Ian Vollick, tfarina, mlamouri+watch-notifications_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use container::back() and container::pop_back() in ui/ Also convert !container.size() to container.empty(). Committed: https://crrev.com/7546d332e2b89c0481836acc25aa7fba6417f4ea Cr-Commit-Position: refs/heads/master@{#405289}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : pre-increment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -54 lines) Patch
M ui/base/ime/win/imm32_manager.cc View 2 chunks +26 lines, -24 lines 0 comments Download
M ui/base/win/open_file_name_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animator_collection.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/mac/screen_mac.mm View 1 1 chunk +2 lines, -4 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_logging.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/message_center/notification_list_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/message_center/popup_timers_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/textfield_model.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M ui/views/layout/grid_layout.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Lei Zhang
4 years, 5 months ago (2016-07-06 22:44:59 UTC) #2
Lei Zhang
ping
4 years, 5 months ago (2016-07-13 16:15:57 UTC) #3
Nico
lgtm Thanks for the nice cleanup! https://codereview.chromium.org/2126433002/diff/1/ui/views/controls/textfield/textfield_model.cc File ui/views/controls/textfield/textfield_model.cc (left): https://codereview.chromium.org/2126433002/diff/1/ui/views/controls/textfield/textfield_model.cc#oldcode481 ui/views/controls/textfield/textfield_model.cc:481: current_edit_ ++; O_o
4 years, 5 months ago (2016-07-13 16:23:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126433002/40001
4 years, 5 months ago (2016-07-13 20:10:27 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-13 21:28:07 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 21:28:19 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 21:30:24 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7546d332e2b89c0481836acc25aa7fba6417f4ea
Cr-Commit-Position: refs/heads/master@{#405289}

Powered by Google App Engine
This is Rietveld 408576698