Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2126323002: Add support for touch-action: pinch-zoom. (Closed)

Created:
4 years, 5 months ago by dtapuska
Modified:
4 years, 2 months ago
Reviewers:
Rick Byers, dcheng
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, jam, dtapuska+chromiumwatch_chromium.org, dglazkov+blink, darin-cc_chromium.org, darktears, blink-reviews, apavlov+blink_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for touch-action: pinch-zoom. This has been enabled behind an experimental web platform feature so that we can test it on a few different devices before we activate it in the wild. Likewise putting this as an experimental feature doesn't require and Intent to Ship just yet. I would like to ship this at the same time we ship touch action pan directions. BUG=626086 Committed: https://crrev.com/0e9eadfcdacea7659dc909851f14215258589b5c Cr-Commit-Position: refs/heads/master@{#421214}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Check in scroll begin for pointer count and add test #

Total comments: 10

Patch Set 3 : Fix nits and tests #

Patch Set 4 : Fix failing tests #

Patch Set 5 : Fix dcheck on debug builds #

Patch Set 6 : Add exception for mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -261 lines) Patch
M content/browser/renderer_host/input/touch_action_filter.cc View 1 2 5 chunks +13 lines, -13 lines 0 comments Download
M content/browser/renderer_host/input/touch_action_filter_unittest.cc View 1 2 3 chunks +33 lines, -18 lines 0 comments Download
M content/common/input_messages.h View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/touch-action-parsing.html View 1 2 1 chunk +0 lines, -73 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/touch-action-parsing-expected.txt View 1 2 1 chunk +0 lines, -120 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/events/pointerevents/pointerevent_touch-action-pinch_zoom_touch.html View 1 2 2 chunks +28 lines, -15 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/events/pointerevents/pointerevent_touch-action-verification.html View 1 2 3 5 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 3 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 4 2 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/public/platform/WebInputEvent.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/blink/blink_event_util.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 40 (27 generated)
dtapuska
Rick care to take a quick look? Ideally I'd like an end to end integration ...
4 years, 5 months ago (2016-07-07 18:20:48 UTC) #3
Rick Byers
On 2016/07/07 18:20:48, dtapuska wrote: > Rick care to take a quick look? > > ...
4 years, 5 months ago (2016-07-07 20:57:18 UTC) #4
Rick Byers
Details all look good - thanks! But I forgot about one design issue - let's ...
4 years, 5 months ago (2016-07-07 21:09:15 UTC) #5
dtapuska
On 2016/07/07 21:09:15, Rick Byers wrote: > Details all look good - thanks! But I ...
4 years, 3 months ago (2016-09-13 15:30:14 UTC) #8
Rick Byers
LGTM with nits https://codereview.chromium.org/2126323002/diff/20001/content/browser/renderer_host/input/touch_action_filter.cc File content/browser/renderer_host/input/touch_action_filter.cc (right): https://codereview.chromium.org/2126323002/diff/20001/content/browser/renderer_host/input/touch_action_filter.cc#newcode52 content/browser/renderer_host/input/touch_action_filter.cc:52: // if there are two or ...
4 years, 3 months ago (2016-09-14 15:47:51 UTC) #11
dtapuska
dcheng@ please review input_messages.h https://codereview.chromium.org/2126323002/diff/20001/content/browser/renderer_host/input/touch_action_filter.cc File content/browser/renderer_host/input/touch_action_filter.cc (right): https://codereview.chromium.org/2126323002/diff/20001/content/browser/renderer_host/input/touch_action_filter.cc#newcode52 content/browser/renderer_host/input/touch_action_filter.cc:52: // if there are two ...
4 years, 3 months ago (2016-09-21 19:29:38 UTC) #15
dtapuska
4 years, 3 months ago (2016-09-21 19:29:53 UTC) #16
dtapuska
On 2016/09/21 19:29:53, dtapuska wrote: dcheng@ ping
4 years, 3 months ago (2016-09-22 16:35:33 UTC) #21
dcheng
ipc lgtm
4 years, 3 months ago (2016-09-22 17:07:20 UTC) #22
Rick Byers
On 2016/09/21 19:29:38, dtapuska wrote: > dcheng@ please review input_messages.h > > https://codereview.chromium.org/2126323002/diff/20001/content/browser/renderer_host/input/touch_action_filter.cc > File ...
4 years, 3 months ago (2016-09-22 17:14:23 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126323002/100001
4 years, 2 months ago (2016-09-27 15:09:01 UTC) #36
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-09-27 15:14:35 UTC) #38
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 15:16:47 UTC) #40
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/0e9eadfcdacea7659dc909851f14215258589b5c
Cr-Commit-Position: refs/heads/master@{#421214}

Powered by Google App Engine
This is Rietveld 408576698