Add support for touch-action: pinch-zoom.

Add support for touch-action: pinch-zoom.

This has been enabled behind an experimental web platform feature so that
we can test it on a few different devices before we activate it in the
wild. Likewise putting this as an experimental feature doesn't require
and Intent to Ship just yet. I would like to ship this at the same time
we ship touch action pan directions.

BUG=626086
Committed: https://crrev.com/0e9eadfcdacea7659dc909851f14215258589b5c
Cr-Commit-Position: refs/heads/master@{#421214}

[dtapuska, 2016-07-07 18:19:50]

Description was changed from

==========
Add support for pinch-zoom.

This has been enabled behind an experimental web platform feature so that
we can test it on a few different devices before we activate it in the
wild. Likewise putting this as an experimental feature doesn't require
and Intent to Ship just yet. I would like to ship this at the same time
we ship touch action pan directions.

BUG=626086
==========

to

==========
Add support for touch-action: pinch-zoom.

This has been enabled behind an experimental web platform feature so that
we can test it on a few different devices before we activate it in the
wild. Likewise putting this as an experimental feature doesn't require
and Intent to Ship just yet. I would like to ship this at the same time
we ship touch action pan directions.

BUG=626086
==========

[dtapuska, 2016-07-07 18:20:48]

dtapuska@chromium.org changed reviewers:
+ rbyers@chromium.org

[dtapuska, 2016-07-07 18:20:48]

Rick care to take a quick look?

Ideally I'd like an end to end integration test; but there aren't really any for
touch-action that work reliably. I have an open bug on that.

[Rick Byers, 2016-07-07 20:57:18]

On 2016/07/07 18:20:48, dtapuska wrote:
> Rick care to take a quick look?
> 
> Ideally I'd like an end to end integration test; but there aren't really any
for
> touch-action that work reliably. I have an open bug on that.

At this point we should just be adding web-platform-tests for this, and
automating them with the gpuBenchmarking extension approach.  ALL our
integration tests should be interop tests ;-)

[Rick Byers, 2016-07-07 21:09:15]

Details all look good - thanks!  But I forgot about one design issue - let's
chat...

https://codereview.chromium.org/2126323002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/touch_action_filter.cc (left):

https://codereview.chromium.org/2126323002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/touch_action_filter.cc:92: // Pinch events
are always bracketed by scroll events, and the W3C
Ah crap, I forgot about this comment I left.

I think this change may break some things.  IIRC we may depend on
GesturePinchUpdate occuring inside of a GestureScroll sequence (pinch events
outside of a scroll sequence were impossible before AFAIK).

Also if we're actually inside of a pinch sequence, then we probably want to
allow scroll events so that two-finger panning during a pinch still works in a
'touch-action: pinch-zoom' region.  Let's chat about options here.

[dtapuska, 2016-09-13 15:29:20]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 15:29:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-09-13 15:30:14]

On 2016/07/07 21:09:15, Rick Byers wrote:
> Details all look good - thanks!  But I forgot about one design issue - let's
> chat...
> 
>
https://codereview.chromium.org/2126323002/diff/1/content/browser/renderer_ho...
> File content/browser/renderer_host/input/touch_action_filter.cc (left):
> 
>
https://codereview.chromium.org/2126323002/diff/1/content/browser/renderer_ho...
> content/browser/renderer_host/input/touch_action_filter.cc:92: // Pinch events
> are always bracketed by scroll events, and the W3C
> Ah crap, I forgot about this comment I left.
> 
> I think this change may break some things.  IIRC we may depend on
> GesturePinchUpdate occuring inside of a GestureScroll sequence (pinch events
> outside of a scroll sequence were impossible before AFAIK).
> 
> Also if we're actually inside of a pinch sequence, then we probably want to
> allow scroll events so that two-finger panning during a pinch still works in a
> 'touch-action: pinch-zoom' region.  Let's chat about options here.

PTAL.

[commit-bot: I haz the power, 2016-09-13 16:17:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 16:17:23]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Rick Byers, 2016-09-14 15:47:51]

LGTM with nits

https://codereview.chromium.org/2126323002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/touch_action_filter.cc (right):

https://codereview.chromium.org/2126323002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/touch_action_filter.cc:52: // if there are
two or more pointers then ensure that we allow panning
nit: wouldn't this make more sense in ShouldSuppressScroll?  I.e. it would be a
bug to ever rely on the return value of ShouldSuppressScroll without also using
this logic.

https://codereview.chromium.org/2126323002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/touch_action_filter.cc:53: // if pinch-zoom
is allowed.
You were going to file a bug to track the subtle behavior difference wrt. edge,
right?  May be worth referencing it here.

https://codereview.chromium.org/2126323002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/touch_action_filter.cc:190: LOG(ERROR) <<
"Got scroll begin";
remove

https://codereview.chromium.org/2126323002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/css/touch-action-parsing.html (right):

https://codereview.chromium.org/2126323002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/touch-action-parsing.html:26: <div
class="test" id="explicit-pinch-zoom" style="touch-action: pinch-zoom;"
expected="pinch-zoom"></div>
now that you have a version of this in WPT, perhaps you should just delete this
LayoutTest (verify that the WPT test is indeed passing of course).

Oh, but we can't update the WPT test until the stupid spec IP issues are
resolved I guess :-(.  So then maybe the best choice is to have an updated copy
of the WPT test here marked as temporary until the spec issue is addressed?

https://codereview.chromium.org/2126323002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/events/pointerevents/pointerevent_touch-action-pinch_zoom_touch.html
(right):

https://codereview.chromium.org/2126323002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/pointerevents/pointerevent_touch-action-pinch_zoom_touch.html:5:
<meta name="assert" content="TA15.4 - With `touch-action: pinch-zoom` on a
swiped or click/dragged element, only pinch zoom and two finger pan should be
possible.">
Add a comment saying this should be upstreamed to WPT once
https://github.com/w3c/pointerevents/issues/29 is resolved

[dtapuska, 2016-09-21 18:50:39]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 18:51:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-09-21 19:29:37]

dtapuska@chromium.org changed reviewers:
+ dcheng@chromium.org

[dtapuska, 2016-09-21 19:29:38]

dcheng@ please review input_messages.h

https://codereview.chromium.org/2126323002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/touch_action_filter.cc (right):

https://codereview.chromium.org/2126323002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/touch_action_filter.cc:52: // if there are
two or more pointers then ensure that we allow panning
On 2016/09/14 15:47:51, Rick Byers (slow until 9-26) wrote:
> nit: wouldn't this make more sense in ShouldSuppressScroll?  I.e. it would be
a
> bug to ever rely on the return value of ShouldSuppressScroll without also
using
> this logic.

Done.

https://codereview.chromium.org/2126323002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/touch_action_filter.cc:53: // if pinch-zoom
is allowed.
On 2016/09/14 15:47:51, Rick Byers (slow until 9-26) wrote:
> You were going to file a bug to track the subtle behavior difference wrt.
edge,
> right?  May be worth referencing it here.

Done.

https://codereview.chromium.org/2126323002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/touch_action_filter.cc:190: LOG(ERROR) <<
"Got scroll begin";
On 2016/09/14 15:47:50, Rick Byers (slow until 9-26) wrote:
> remove

Done.

https://codereview.chromium.org/2126323002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/css/touch-action-parsing.html (right):

https://codereview.chromium.org/2126323002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/touch-action-parsing.html:26: <div
class="test" id="explicit-pinch-zoom" style="touch-action: pinch-zoom;"
expected="pinch-zoom"></div>
On 2016/09/14 15:47:51, Rick Byers (slow until 9-26) wrote:
> now that you have a version of this in WPT, perhaps you should just delete
this
> LayoutTest (verify that the WPT test is indeed passing of course).
> 
> Oh, but we can't update the WPT test until the stupid spec IP issues are
> resolved I guess :-(.  So then maybe the best choice is to have an updated
copy
> of the WPT test here marked as temporary until the spec issue is addressed?

Done.

https://codereview.chromium.org/2126323002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/events/pointerevents/pointerevent_touch-action-pinch_zoom_touch.html
(right):

https://codereview.chromium.org/2126323002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/pointerevents/pointerevent_touch-action-pinch_zoom_touch.html:5:
<meta name="assert" content="TA15.4 - With `touch-action: pinch-zoom` on a
swiped or click/dragged element, only pinch zoom and two finger pan should be
possible.">
On 2016/09/14 15:47:51, Rick Byers (slow until 9-26) wrote:
> Add a comment saying this should be upstreamed to WPT once
> https://github.com/w3c/pointerevents/issues/29 is resolved

Done.

[commit-bot: I haz the power, 2016-09-21 20:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 20:28:01]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dtapuska, 2016-09-22 15:48:43]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 15:49:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-09-22 16:35:33]

On 2016/09/21 19:29:53, dtapuska wrote:

dcheng@ ping

[dcheng, 2016-09-22 17:07:20]

ipc lgtm

[Rick Byers, 2016-09-22 17:14:23]

On 2016/09/21 19:29:38, dtapuska wrote:
> dcheng@ please review input_messages.h
> 
>
https://codereview.chromium.org/2126323002/diff/20001/content/browser/rendere...
> File content/browser/renderer_host/input/touch_action_filter.cc (right):
> 
>
https://codereview.chromium.org/2126323002/diff/20001/content/browser/rendere...
> content/browser/renderer_host/input/touch_action_filter.cc:52: // if there are
> two or more pointers then ensure that we allow panning
> On 2016/09/14 15:47:51, Rick Byers (slow until 9-26) wrote:
> > nit: wouldn't this make more sense in ShouldSuppressScroll?  I.e. it would
be
> a
> > bug to ever rely on the return value of ShouldSuppressScroll without also
> using
> > this logic.
> 
> Done.
> 
>
https://codereview.chromium.org/2126323002/diff/20001/content/browser/rendere...
> content/browser/renderer_host/input/touch_action_filter.cc:53: // if
pinch-zoom
> is allowed.
> On 2016/09/14 15:47:51, Rick Byers (slow until 9-26) wrote:
> > You were going to file a bug to track the subtle behavior difference wrt.
> edge,
> > right?  May be worth referencing it here.
> 
> Done.
> 
>
https://codereview.chromium.org/2126323002/diff/20001/content/browser/rendere...
> content/browser/renderer_host/input/touch_action_filter.cc:190: LOG(ERROR) <<
> "Got scroll begin";
> On 2016/09/14 15:47:50, Rick Byers (slow until 9-26) wrote:
> > remove
> 
> Done.
> 
>
https://codereview.chromium.org/2126323002/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/fast/css/touch-action-parsing.html
(right):
> 
>
https://codereview.chromium.org/2126323002/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/fast/css/touch-action-parsing.html:26: <div
> class="test" id="explicit-pinch-zoom" style="touch-action: pinch-zoom;"
> expected="pinch-zoom"></div>
> On 2016/09/14 15:47:51, Rick Byers (slow until 9-26) wrote:
> > now that you have a version of this in WPT, perhaps you should just delete
> this
> > LayoutTest (verify that the WPT test is indeed passing of course).
> > 
> > Oh, but we can't update the WPT test until the stupid spec IP issues are
> > resolved I guess :-(.  So then maybe the best choice is to have an updated
> copy
> > of the WPT test here marked as temporary until the spec issue is addressed?
> 
> Done.
> 
>
https://codereview.chromium.org/2126323002/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/fast/events/pointerevents/pointerevent_touch-action-pinch_zoom_touch.html
> (right):
> 
>
https://codereview.chromium.org/2126323002/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/events/pointerevents/pointerevent_touch-action-pinch_zoom_touch.html:5:
> <meta name="assert" content="TA15.4 - With `touch-action: pinch-zoom` on a
> swiped or click/dragged element, only pinch zoom and two finger pan should be
> possible.">
> On 2016/09/14 15:47:51, Rick Byers (slow until 9-26) wrote:
> > Add a comment saying this should be upstreamed to WPT once
> > https://github.com/w3c/pointerevents/issues/29 is resolved
> 
> Done.

Note that I just got agreement (today) from web-platform-test folks that it's
fine to include tests of non-standard but largely interoperable behavior in WPT
as long as the test is clearly marked as "defacto" (not representing some spec).
 This seems to imply.  Not worth blocking this patch on, but you're free to
upload these tests to WPT anytime you like, just put a 'defacto-' prefix in the
filename or something.


Still LGTM

[commit-bot: I haz the power, 2016-09-22 17:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:49:57]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dtapuska, 2016-09-26 18:23:34]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 18:24:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 20:03:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 20:03:28]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dtapuska, 2016-09-27 13:06:29]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 13:06:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:04:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 15:04:45]

Dry run: This issue passed the CQ dry run.

[dtapuska, 2016-09-27 15:08:43]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-09-27 15:08:43]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2126323002/#ps100001
(title: "Add exception for mac")

[commit-bot: I haz the power, 2016-09-27 15:09:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:14:32]

Description was changed from

==========
Add support for touch-action: pinch-zoom.

This has been enabled behind an experimental web platform feature so that
we can test it on a few different devices before we activate it in the
wild. Likewise putting this as an experimental feature doesn't require
and Intent to Ship just yet. I would like to ship this at the same time
we ship touch action pan directions.

BUG=626086
==========

to

==========
Add support for touch-action: pinch-zoom.

This has been enabled behind an experimental web platform feature so that
we can test it on a few different devices before we activate it in the
wild. Likewise putting this as an experimental feature doesn't require
and Intent to Ship just yet. I would like to ship this at the same time
we ship touch action pan directions.

BUG=626086
==========

[commit-bot: I haz the power, 2016-09-27 15:14:35]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-27 15:16:46]

Description was changed from

==========
Add support for touch-action: pinch-zoom.

This has been enabled behind an experimental web platform feature so that
we can test it on a few different devices before we activate it in the
wild. Likewise putting this as an experimental feature doesn't require
and Intent to Ship just yet. I would like to ship this at the same time
we ship touch action pan directions.

BUG=626086
==========

to

==========
Add support for touch-action: pinch-zoom.

This has been enabled behind an experimental web platform feature so that
we can test it on a few different devices before we activate it in the
wild. Likewise putting this as an experimental feature doesn't require
and Intent to Ship just yet. I would like to ship this at the same time
we ship touch action pan directions.

BUG=626086

Committed: https://crrev.com/0e9eadfcdacea7659dc909851f14215258589b5c
Cr-Commit-Position: refs/heads/master@{#421214}
==========

[commit-bot: I haz the power, 2016-09-27 15:16:47]

Patchset 6 (id:??) landed as
https://crrev.com/0e9eadfcdacea7659dc909851f14215258589b5c
Cr-Commit-Position: refs/heads/master@{#421214}