Check granularity in render pass bounds

Check granularity in render pass bounds

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126303002

Committed: https://skia.googlesource.com/skia/+/27bb28473912181cf9a838e9282e86cb62e2d44b

[egdaniel, 2016-07-07 16:56:05]

Description was changed from

==========
Check granularity in render pass bounds

BUG=skia:
==========

to

==========
Check granularity in render pass bounds

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126303002
==========

[egdaniel, 2016-07-07 16:59:30]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com

[jvanverth1, 2016-07-07 18:05:34]

lgtm + one comment

https://codereview.chromium.org/2126303002/diff/1/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/2126303002/diff/1/src/gpu/vk/GrVkGpu.cpp#newc...
src/gpu/vk/GrVkGpu.cpp:1506: int rightAdj = srcBounds.fRight %
granularity.width;
This looks correct. But it seems like it should be a lot like alignment, so
dstRight = (right+granularity.width-1) & ~(granularity.width-1). Elsewhere in
the doc it specifies that image granularity is a power of 2, I'd assume this is
the same.

[egdaniel, 2016-07-07 18:44:59]

https://codereview.chromium.org/2126303002/diff/1/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/2126303002/diff/1/src/gpu/vk/GrVkGpu.cpp#newc...
src/gpu/vk/GrVkGpu.cpp:1506: int rightAdj = srcBounds.fRight %
granularity.width;
On 2016/07/07 18:05:34, jvanverth1 wrote:
> This looks correct. But it seems like it should be a lot like alignment, so
> dstRight = (right+granularity.width-1) & ~(granularity.width-1). Elsewhere in
> the doc it specifies that image granularity is a power of 2, I'd assume this
is
> the same.

I would imagine in practice the granularity (if there even is one) would be a
power of two. But the spec doesn't say this is required as it does for
granularity of other objects. So I'm going to leave this as is until we find out
otherwise.

[egdaniel, 2016-07-07 18:45:09]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-07-07 18:45:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 18:58:38]

Description was changed from

==========
Check granularity in render pass bounds

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126303002
==========

to

==========
Check granularity in render pass bounds

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126303002

Committed:
https://skia.googlesource.com/skia/+/27bb28473912181cf9a838e9282e86cb62e2d44b
==========

[commit-bot: I haz the power, 2016-07-07 18:58:39]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/27bb28473912181cf9a838e9282e86cb62e2d44b