Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 2126253002: centralize VECTORCALL as SK_VECTORCALL (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

centralize VECTORCALL as SK_VECTORCALL Gonna start using this, might as well define it once centrally. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126253002 No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/e5fb9c8079c7838aafe38c9a47ef1e87d77dc56f

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -41 lines) Patch
M include/core/SkPostConfig.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/core/SkLinearBitmapPipeline.cpp View 13 chunks +16 lines, -16 lines 0 comments Download
M src/core/SkLinearBitmapPipeline_core.h View 4 chunks +5 lines, -14 lines 0 comments Download
M src/core/SkLinearBitmapPipeline_sample.h View 9 chunks +9 lines, -9 lines 0 comments Download
M tests/SkLinearBitmapPipelineTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
mtklein_C
4 years, 5 months ago (2016-07-07 14:28:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126253002/1
4 years, 5 months ago (2016-07-07 14:28:57 UTC) #6
herb_g
lgtm
4 years, 5 months ago (2016-07-07 14:30:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126253002/1
4 years, 5 months ago (2016-07-07 14:31:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/9491)
4 years, 5 months ago (2016-07-07 14:32:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126253002/20001
4 years, 5 months ago (2016-07-07 14:34:47 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/9583)
4 years, 5 months ago (2016-07-07 14:41:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126253002/40001
4 years, 5 months ago (2016-07-07 14:44:38 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 15:12:12 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e5fb9c8079c7838aafe38c9a47ef1e87d77dc56f

Powered by Google App Engine
This is Rietveld 408576698