[Payments] Record use of profiles and credit cards in Payment Request.

chrome/browser/autofill/android/personal_data_manager_android.cc

Index: chrome/browser/autofill/android/personal_data_manager_android.cc
diff --git a/chrome/browser/autofill/android/personal_data_manager_android.cc b/chrome/browser/autofill/android/personal_data_manager_android.cc
index 03e9be0c33efe120a6e8ac66e4819050459f635c..d4f68f338c26df0f93c96655a8a916be2aa42d95 100644
--- a/chrome/browser/autofill/android/personal_data_manager_android.cc
+++ b/chrome/browser/autofill/android/personal_data_manager_android.cc
@@ -492,6 +492,18 @@ bool PersonalDataManagerAndroid::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
+void PersonalDataManagerAndroid::RecordAndLogProfileUse(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& unused_obj,
+    const JavaParamRef<jstring>& jguid) {
+  AutofillProfile* profile = personal_data_manager_->GetProfileByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!profile)

[please use gerrit instead, 2016/07/12 15:41:58]

Early returns are only useful when the rest of the function is huge. Here, the
rest of the function is a single line. So you can save 2 lines of code by doing
this instead:

if (profile)
  profile->RecordAndLogUse();

[sebsg, 2016/07/13 18:49:20]

Done.

+    return;
+
+  profile->RecordAndLogUse();
+}
+
 void PersonalDataManagerAndroid::SetProfileUseStatsForTesting(
     JNIEnv* env,
     const JavaParamRef<jobject>& unused_obj,
@@ -509,6 +521,42 @@ void PersonalDataManagerAndroid::SetProfileUseStatsForTesting(
   profile->set_use_date(base::Time::FromTimeT(date));
 }
 
+jint PersonalDataManagerAndroid::GetProfileUseCountForTesting(
+    JNIEnv* env,
+    const base::android::JavaParamRef<jobject>& unused_obj,
+    const base::android::JavaParamRef<jstring>& jguid) {
+  AutofillProfile* profile = personal_data_manager_->GetProfileByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!profile)

[please use gerrit instead, 2016/07/12 15:41:58]

Ternary operator saves space for very short lines.

return profile ? profile->use_count() : -1;

[sebsg, 2016/07/13 18:49:20]

Done.

+    return -1;
+
+  return profile->use_count();
+}
+
+jlong PersonalDataManagerAndroid::GetProfileUseDateForTesting(
+    JNIEnv* env,
+    const base::android::JavaParamRef<jobject>& unused_obj,
+    const base::android::JavaParamRef<jstring>& jguid) {
+  AutofillProfile* profile = personal_data_manager_->GetProfileByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!profile)

[please use gerrit instead, 2016/07/12 15:41:58]

Ditto

[sebsg, 2016/07/13 18:49:20]

Done.

+    return -1;
+
+  return profile->use_date().ToTimeT();
+}
+
+void PersonalDataManagerAndroid::RecordAndLogCreditCardUse(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& unused_obj,
+    const JavaParamRef<jstring>& jguid) {
+  CreditCard* card = personal_data_manager_->GetCreditCardByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!card)

[please use gerrit instead, 2016/07/12 15:41:58]

Ditto

[sebsg, 2016/07/13 18:49:20]

Done.

+    return;
+
+  card->RecordAndLogUse();
+}
+
 void PersonalDataManagerAndroid::SetCreditCardUseStatsForTesting(
     JNIEnv* env,
     const JavaParamRef<jobject>& unused_obj,
@@ -526,6 +574,36 @@ void PersonalDataManagerAndroid::SetCreditCardUseStatsForTesting(
   card->set_use_date(base::Time::FromTimeT(date));
 }
 
+jint PersonalDataManagerAndroid::GetCreditCardUseCountForTesting(
+    JNIEnv* env,
+    const base::android::JavaParamRef<jobject>& unused_obj,
+    const base::android::JavaParamRef<jstring>& jguid) {
+  CreditCard* card = personal_data_manager_->GetCreditCardByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!card)

[please use gerrit instead, 2016/07/12 15:41:58]

Ditto

[sebsg, 2016/07/13 18:49:20]

Done.

+    return -1;
+
+  return card->use_count();
+}
+
+jlong PersonalDataManagerAndroid::GetCreditCardUseDateForTesting(
+    JNIEnv* env,
+    const base::android::JavaParamRef<jobject>& unused_obj,
+    const base::android::JavaParamRef<jstring>& jguid){
+  CreditCard* card = personal_data_manager_->GetCreditCardByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!card)

[please use gerrit instead, 2016/07/12 15:41:58]

Ditto

[sebsg, 2016/07/13 18:49:20]

Done.

+    return -1;
+
+  return card->use_date().ToTimeT();
+}
+
+jlong PersonalDataManagerAndroid::GetCurrentDateForTesting(
+    JNIEnv* env,
+    const base::android::JavaParamRef<jobject>& unused_obj) {
+  return base::Time::Now().ToTimeT();
+}
+
 ScopedJavaLocalRef<jobjectArray> PersonalDataManagerAndroid::GetProfileGUIDs(
     JNIEnv* env,
     const std::vector<AutofillProfile*>& profiles) {