[Payments] Record use of profiles and credit cards in Payment Request.

chrome/browser/autofill/android/personal_data_manager_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/android/personal_data_manager_android.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <memory>
 #include <utility>
@@ skipping 474 matching lines @@
 
   Java_PersonalDataManager_personalDataChanged(env,
                                                weak_java_obj_.get(env).obj());
 }
 
 // static
 bool PersonalDataManagerAndroid::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
+void PersonalDataManagerAndroid::RecordAndLogProfileUse(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& unused_obj,
+    const JavaParamRef<jstring>& jguid) {
+  AutofillProfile* profile = personal_data_manager_->GetProfileByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!profile)

[please use gerrit instead, 2016/07/12 15:41:58]

Early returns are only useful when the rest of the function is huge. Here, the
rest of the function is a single line. So you can save 2 lines of code by doing
this instead:

if (profile)
  profile->RecordAndLogUse();

[sebsg, 2016/07/13 18:49:20]

Done.

+    return;
+
+  profile->RecordAndLogUse();
+}
+
 void PersonalDataManagerAndroid::SetProfileUseStatsForTesting(
     JNIEnv* env,
     const JavaParamRef<jobject>& unused_obj,
     const JavaParamRef<jstring>& jguid,
     jint count,
     jint date) {
   DCHECK(count >= 0 && date >= 0);
 
   AutofillProfile* profile = personal_data_manager_->GetProfileByGUID(
       ConvertJavaStringToUTF8(env, jguid));
   if (!profile)
     return;
 
   profile->set_use_count(static_cast<size_t>(count));
   profile->set_use_date(base::Time::FromTimeT(date));
 }
 
+jint PersonalDataManagerAndroid::GetProfileUseCountForTesting(
+    JNIEnv* env,
+    const base::android::JavaParamRef<jobject>& unused_obj,
+    const base::android::JavaParamRef<jstring>& jguid) {
+  AutofillProfile* profile = personal_data_manager_->GetProfileByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!profile)

[please use gerrit instead, 2016/07/12 15:41:58]

Ternary operator saves space for very short lines.

return profile ? profile->use_count() : -1;

[sebsg, 2016/07/13 18:49:20]

Done.

+    return -1;
+
+  return profile->use_count();
+}
+
+jlong PersonalDataManagerAndroid::GetProfileUseDateForTesting(
+    JNIEnv* env,
+    const base::android::JavaParamRef<jobject>& unused_obj,
+    const base::android::JavaParamRef<jstring>& jguid) {
+  AutofillProfile* profile = personal_data_manager_->GetProfileByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!profile)

[please use gerrit instead, 2016/07/12 15:41:58]

Ditto

[sebsg, 2016/07/13 18:49:20]

Done.

+    return -1;
+
+  return profile->use_date().ToTimeT();
+}
+
+void PersonalDataManagerAndroid::RecordAndLogCreditCardUse(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& unused_obj,
+    const JavaParamRef<jstring>& jguid) {
+  CreditCard* card = personal_data_manager_->GetCreditCardByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!card)

[please use gerrit instead, 2016/07/12 15:41:58]

Ditto

[sebsg, 2016/07/13 18:49:20]

Done.

+    return;
+
+  card->RecordAndLogUse();
+}
+
 void PersonalDataManagerAndroid::SetCreditCardUseStatsForTesting(
     JNIEnv* env,
     const JavaParamRef<jobject>& unused_obj,
     const JavaParamRef<jstring>& jguid,
     jint count,
     jint date) {
   DCHECK(count >= 0 && date >= 0);
 
   CreditCard* card = personal_data_manager_->GetCreditCardByGUID(
       ConvertJavaStringToUTF8(env, jguid));
   if (!card)
     return;
 
   card->set_use_count(static_cast<size_t>(count));
   card->set_use_date(base::Time::FromTimeT(date));
 }
 
+jint PersonalDataManagerAndroid::GetCreditCardUseCountForTesting(
+    JNIEnv* env,
+    const base::android::JavaParamRef<jobject>& unused_obj,
+    const base::android::JavaParamRef<jstring>& jguid) {
+  CreditCard* card = personal_data_manager_->GetCreditCardByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!card)

[please use gerrit instead, 2016/07/12 15:41:58]

Ditto

[sebsg, 2016/07/13 18:49:20]

Done.

+    return -1;
+
+  return card->use_count();
+}
+
+jlong PersonalDataManagerAndroid::GetCreditCardUseDateForTesting(
+    JNIEnv* env,
+    const base::android::JavaParamRef<jobject>& unused_obj,
+    const base::android::JavaParamRef<jstring>& jguid){
+  CreditCard* card = personal_data_manager_->GetCreditCardByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!card)

[please use gerrit instead, 2016/07/12 15:41:58]

Ditto

[sebsg, 2016/07/13 18:49:20]

Done.

+    return -1;
+
+  return card->use_date().ToTimeT();
+}
+
+jlong PersonalDataManagerAndroid::GetCurrentDateForTesting(
+    JNIEnv* env,
+    const base::android::JavaParamRef<jobject>& unused_obj) {
+  return base::Time::Now().ToTimeT();
+}
+
 ScopedJavaLocalRef<jobjectArray> PersonalDataManagerAndroid::GetProfileGUIDs(
     JNIEnv* env,
     const std::vector<AutofillProfile*>& profiles) {
   std::vector<base::string16> guids;
   for (AutofillProfile* profile : profiles)
     guids.push_back(base::UTF8ToUTF16(profile->guid()));
 
   return base::android::ToJavaArrayOfStrings(env, guids);
 }
 
@@ skipping 80 matching lines @@
                base::android::ConvertJavaStringToUTF16(env, jcountry_name)));
 }
 
 static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   PersonalDataManagerAndroid* personal_data_manager_android =
       new PersonalDataManagerAndroid(env, obj);
   return reinterpret_cast<intptr_t>(personal_data_manager_android);
 }
 
 }  // namespace autofill