Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2126103003: Change chrome:// favicons in tabstrip based on theming. (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 5 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Change chrome:// favicons in tabstrip based on theming. This hack is cool because it works for incognito and themes, but it's not cool because it will have to be copied over for bookmark buttons and normal websites that have the same issue with their icons can't address it in the same way. BUG=526663 TBR=groby@chromium.org Review-Url: https://codereview.chromium.org/2091053002 Cr-Commit-Position: refs/heads/master@{#403581} (cherry picked from commit 80c47667a3be9304f80c055bd5611527e67fcbe5) Committed: https://chromium.googlesource.com/chromium/src/+/fb041b5e63215ed99f7cc9dfc7bb493ad3a3b624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -28 lines) Patch
M chrome/browser/themes/theme_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/download/background_theme.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/download/background_theme.mm View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 2 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.h View 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 9 chunks +52 lines, -15 lines 0 comments Download
M ui/base/default_theme_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/default_theme_provider.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/base/theme_provider.h View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
4 years, 5 months ago (2016-07-07 20:11:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fb041b5e63215ed99f7cc9dfc7bb493ad3a3b624.

Powered by Google App Engine
This is Rietveld 408576698