Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/browser/ui/libgtk2ui/gtk2_ui.cc

Issue 2126103003: Change chrome:// favicons in tabstrip based on theming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/libgtk2ui/gtk2_ui.cc
diff --git a/chrome/browser/ui/libgtk2ui/gtk2_ui.cc b/chrome/browser/ui/libgtk2ui/gtk2_ui.cc
index 355228e12a988b557dc7feb37b9c23106445d4e4..c9d25bf01e9e97f73b4168472b4b11f73167003c 100644
--- a/chrome/browser/ui/libgtk2ui/gtk2_ui.cc
+++ b/chrome/browser/ui/libgtk2ui/gtk2_ui.cc
@@ -557,9 +557,12 @@ gfx::Image Gtk2UI::GetThemeImageNamed(int id) const {
bool Gtk2UI::GetTint(int id, color_utils::HSL* tint) const {
switch (id) {
+ // Tints for which the cross-platform default is fine. Before adding new
+ // values here, specifically verify they work well on Linux.
case ThemeProperties::TINT_BACKGROUND_TAB:
- // Tints for which the cross-platform default is fine. Before adding new
- // values here, specifically verify they work well on Linux.
+ // TODO(estade): Return something useful for TINT_BUTTONS so that chrome://
+ // page icons are colored appropriately.
+ case ThemeProperties::TINT_BUTTONS:
break;
default:
// Assume any tints not specifically verified on Linux aren't usable.
« no previous file with comments | « chrome/browser/ui/cocoa/download/background_theme.mm ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698