Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: media/renderers/skcanvas_video_renderer.cc

Issue 2126053002: Avoid copying NV12 GL_TEXTURE_EXTERNAL_OES textures for use with skia. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/skcanvas_video_renderer.cc
diff --git a/media/renderers/skcanvas_video_renderer.cc b/media/renderers/skcanvas_video_renderer.cc
index df59249862b7157b68704f493dd636c0ea7151a5..74e72bc5a4c5338b654097de6de29fa321a9b611 100644
--- a/media/renderers/skcanvas_video_renderer.cc
+++ b/media/renderers/skcanvas_video_renderer.cc
@@ -109,9 +109,9 @@ sk_sp<SkImage> NewSkImageFromVideoFrameYUVTextures(
source_textures[i].fTarget = mailbox_holder.texture_target;
// TODO(dcastagna): avoid this copy once Skia supports native textures
- // with a texture target different than TEXTURE_2D.
+ // with a GL_TEXTURE_RECTANGLE_ARB texture target.
// crbug.com/505026
- if (mailbox_holder.texture_target != GL_TEXTURE_2D) {
+ if (mailbox_holder.texture_target == GL_TEXTURE_RECTANGLE_ARB) {
unsigned texture_copy = 0;
gl->GenTextures(1, &texture_copy);
DCHECK(texture_copy);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698