Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 212593008: Bindings: rename |resultValue| => |jsValue| (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_attributes.py
diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py
index b50ab4e80beabb8baf974ba9c2e7c7f602e36320..3fed35bb61ee477fa05c3371c23cf27ad865ece7 100644
--- a/Source/bindings/scripts/v8_attributes.py
+++ b/Source/bindings/scripts/v8_attributes.py
@@ -169,6 +169,7 @@ def generate_getter(interface, attribute, contents):
if (idl_type.is_nullable or
base_idl_type == 'EventHandler' or
'CachedAttribute' in extended_attributes or
+ 'ReflectOnly' in extended_attributes or
contents['is_getter_raises_exception']):
contents['cpp_value_original'] = cpp_value
cpp_value = 'jsValue'
@@ -176,11 +177,6 @@ def generate_getter(interface, attribute, contents):
if base_idl_type != 'EventHandler' and idl_type.is_interface_type:
release = True
- if 'ReflectOnly' in extended_attributes:
- contents['cpp_value_original'] = cpp_value
- # FIXME: rename to jsValue
- cpp_value = 'resultValue'
-
def v8_set_return_value_statement(for_main_world=False):
if contents['is_keep_alive_for_gc']:
return 'v8SetReturnValue(info, wrapper)'
« no previous file with comments | « no previous file | Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698