Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 212593008: Bindings: rename |resultValue| => |jsValue| (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/attributes.cpp
diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp
index 78e926b5eec318616c47ebbee81b3bab0cf4247a..c873f3731cefbec93507d21da8e3a2cfe8bbc56f 100644
--- a/Source/bindings/templates/attributes.cpp
+++ b/Source/bindings/templates/attributes.cpp
@@ -117,31 +117,30 @@ const v8::PropertyCallbackInfo<v8::Value>& info
{# Attribute is limited to only known values: check that the attribute value is
one of those. If not, set it to the empty string.
http://www.whatwg.org/specs/web-apps/current-work/#limited-to-only-known-values #}
-{# FIXME: rename resultValue to jsValue #}
{% if reflect_empty %}
-if (resultValue.isNull()) {
+if (jsValue.isNull()) {
{% if reflect_missing %}
- resultValue = "{{reflect_missing}}";
+ jsValue = "{{reflect_missing}}";
{% else %}
;
{% endif %}
-} else if (resultValue.isEmpty()) {
- resultValue = "{{reflect_empty}}";
+} else if (jsValue.isEmpty()) {
+ jsValue = "{{reflect_empty}}";
{% else %}
-if (resultValue.isEmpty()) {
+if (jsValue.isEmpty()) {
{# FIXME: should use [ReflectEmpty] instead; need to change IDL files #}
{% if reflect_missing %}
- resultValue = "{{reflect_missing}}";
+ jsValue = "{{reflect_missing}}";
{% else %}
;
{% endif %}
{% endif %}
{% for value in reflect_only_values %}
-} else if (equalIgnoringCase(resultValue, "{{value}}")) {
- resultValue = "{{value}}";
+} else if (equalIgnoringCase(jsValue, "{{value}}")) {
+ jsValue = "{{value}}";
{% endfor %}
} else {
- resultValue = "{{reflect_invalid}}";
+ jsValue = "{{reflect_invalid}}";
}
{% endmacro %}
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698