Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 212593008: Bindings: rename |resultValue| => |jsValue| (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Bindings: rename |resultValue| => |jsValue| Fixes irregular naming in [ReflectOnly], simplifies code. Fixes 2 FIXMEs. BUG=345503 TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -162 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 2 chunks +1 line, -5 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 1 chunk +9 lines, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 8 chunks +78 lines, -78 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 7 chunks +69 lines, -69 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nils Barth (inactive)
6 years, 9 months ago (2014-03-27 02:54:37 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-27 02:54:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/212593008/1
6 years, 9 months ago (2014-03-27 02:54:43 UTC) #3
haraken
We're mixing |jsValue| and |v8Value| as well. I think we should unify them to |v8Value|.
6 years, 9 months ago (2014-03-27 02:55:45 UTC) #4
Nils Barth (inactive)
On 2014/03/27 02:55:45, haraken wrote: > We're mixing |jsValue| and |v8Value| as well. I think ...
6 years, 9 months ago (2014-03-27 02:58:19 UTC) #5
commit-bot: I haz the power
Change committed as 170128
6 years, 9 months ago (2014-03-27 03:56:42 UTC) #6
Nils Barth (inactive)
BTW, is this LGTY?
6 years, 9 months ago (2014-03-27 04:06:12 UTC) #7
haraken
On 2014/03/27 04:06:12, Nils Barth wrote: > BTW, is this LGTY? LGTM if you rename ...
6 years, 9 months ago (2014-03-27 04:19:55 UTC) #8
Nils Barth (inactive)
6 years, 9 months ago (2014-03-27 05:28:48 UTC) #9
Message was sent while issue was closed.
On 2014/03/27 04:19:55, haraken wrote:
> On 2014/03/27 04:06:12, Nils Barth wrote:
> > BTW, is this LGTY?
> 
> LGTM if you rename |jsValue| to |v8Value| in a follow-up :)

Done!
Bindings: rename |jsValue| => |v8Value|
https://codereview.chromium.org/214283002/

Powered by Google App Engine
This is Rietveld 408576698