Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 2125913003: [BlobAsync] Fixed shared memory mapping (Closed)

Created:
4 years, 5 months ago by dmurph
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[BlobAsync] Fixed shared memory mapping The test was designed to catch this case, but because the memory was mapped before we sent it to the class, the incorrect call to Map was a no-op. Test has been fixed. BUG=619217 Review-Url: https://codereview.chromium.org/2086033002 Cr-Commit-Position: refs/heads/master@{#401053} (cherry picked from commit 8731540b822e48124e782a976ef5d44632757a29) Review URL: https://codereview.chromium.org/2094493002 . Cr-Commit-Position: refs/branch-heads/2743@{#448} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} (cherry picked from commit 1763362b4662d9c8499b5725461da783659cacac) Committed: https://chromium.googlesource.com/chromium/src/+/3ad99e08f3122f5a5b2512b9acec4e981b3072d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M content/child/blob_storage/blob_transport_controller.cc View 2 chunks +17 lines, -1 line 0 comments Download
M content/child/blob_storage/blob_transport_controller_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dmurph
4 years, 5 months ago (2016-07-06 18:43:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3ad99e08f3122f5a5b2512b9acec4e981b3072d6.

Powered by Google App Engine
This is Rietveld 408576698