Issue 2094493002: [BlobAsync] Fixed shared memory mapping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2094493002: [BlobAsync] Fixed shared memory mapping (Closed)

Created:
4 years, 6 months ago by dmurph

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

[BlobAsync] Fixed shared memory mapping The test was designed to catch this case, but because the memory was mapped before we sent it to the class, the incorrect call to Map was a no-op. Test has been fixed. BUG=619217 Review-Url: https://codereview.chromium.org/2086033002 Cr-Commit-Position: refs/heads/master@{#401053} (cherry picked from commit 8731540b822e48124e782a976ef5d44632757a29) Committed: https://chromium.googlesource.com/chromium/src/+/1763362b4662d9c8499b5725461da783659cacac

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	content/child/blob_storage/blob_transport_controller.cc	View		2 chunks	+17 lines, -1 line	0 comments	Download
	M	content/child/blob_storage/blob_transport_controller_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

dmurph

4 years, 6 months ago (2016-06-22 20:33:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1763362b4662d9c8499b5725461da783659cacac.