Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(319)

Issue 21259: Fix bugs related to making Chrome default browser on Vista. (Closed)

Created:
10 years, 6 months ago by kuchhal
Modified:
8 years, 3 months ago
Reviewers:
huanr, robertshield
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix bugs related to making Chrome default browser on Vista and also do some cleanup. - Stupid bug where we were failing if there was a space or '-' in the path to setup.exe - Some application still read default browser from Software\Classes\http even on Vista so set that - Some refactoring of apppaths changes to make a method private that doesn't need to be public. - Move constants in shell_util where rest of the shell related constants are. - Remove duplicate attempts to create ChromeHTML key BUG=7568, 6732, 6504

Patch Set 1 #

Patch Set 2 : fix typo #

Patch Set 3 : after merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -82 lines) Patch
M chrome/installer/setup/uninstall.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/installer/util/shell_util.h View 1 3 chunks +5 lines, -10 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 11 chunks +49 lines, -60 lines 0 comments Download
M chrome/installer/util/util_constants.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/util/util_constants.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kuchhal
10 years, 6 months ago (2009-02-11 20:56:16 UTC) #1
robertshield
On 2009/02/11 20:56:16, kuchhal wrote: > LGTM
10 years, 6 months ago (2009-02-11 21:40:31 UTC) #2
huanr
10 years, 6 months ago (2009-02-11 23:53:26 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698