Issue 21259: Fix bugs related to making Chrome default browser on Vista.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21259: Fix bugs related to making Chrome default browser on Vista. (Closed)

Created:
11 years, 10 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
huanr, robertshield

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix bugs related to making Chrome default browser on Vista and also do some cleanup. - Stupid bug where we were failing if there was a space or '-' in the path to setup.exe - Some application still read default browser from Software\Classes\http even on Vista so set that - Some refactoring of apppaths changes to make a method private that doesn't need to be public. - Move constants in shell_util where rest of the shell related constants are. - Remove duplicate attempts to create ChromeHTML key BUG=7568, 6732, 6504

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -82 lines)			Patch
M	chrome/installer/setup/uninstall.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/installer/util/shell_util.h	View	1	3 chunks	+5 lines, -10 lines	0 comments	Download
M	chrome/installer/util/shell_util.cc	View	1	11 chunks	+49 lines, -60 lines	0 comments	Download
M	chrome/installer/util/util_constants.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/installer/util/util_constants.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 21259: Fix bugs related to making Chrome default browser on Vista. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix typo #

Patch Set 3 : after merge #

Messages