Issue 2125893002: Implement AwPermissionManager::RequestPermissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2125893002: Implement AwPermissionManager::RequestPermissions (Closed)

Created:
4 years, 5 months ago by Takashi Toyoshima

Modified:
4 years, 5 months ago

Reviewers:
Tobias Sargeant

CC:
chromium-reviews, blink-reviews, haraken, android-webview-reviews_chromium.org, toyoshim+midi_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@midi_mojo

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Implement AwPermissionManager::RequestPermissions Once https://codereview.chromium.org/2116763002/ is submitted, I will ask code review on this CL. BUG=582328

Patch Set 1 #

Patch Set 2 : done #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -200 lines)			Patch
M	android_webview/browser/aw_permission_manager.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	android_webview/browser/aw_permission_manager.cc	View	1	5 chunks	+232 lines, -168 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp	View		2 chunks	+9 lines, -29 lines	0 comments	Download

Depends on Patchset:

Issue 2116763002 Patch 100001

Messages

Total messages: 2 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Takashi Toyoshima

Description was changed from ========== WIP: Implement AwPermissionManager::RequestPermissions This will follow https://codereview.chromium.org/2116763002/ BUG=582328 ========== to ...

4 years, 5 months ago (2016-07-07 11:04:22 UTC) #1

Takashi Toyoshima

4 years, 5 months ago (2016-07-07 11:04:22 UTC) #2

toyoshim@chromium.org changed reviewers:
+ tobiasjs@chromium.org

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages