Issue 2125873002: Version 5.2.361.35 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2125873002: Version 5.2.361.35 (cherry-pick) (Closed)

Created:
4 years, 5 months ago by epertoso

Modified:
4 years, 5 months ago

Reviewers:
mvstanton, Michael Hablich

CC:
Paweł Hajdan Jr., ulan, v8-merges_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@5.2

Target Ref:
refs/pending/branch-heads/5.2

Project:
v8

Visibility:
Public.

More Reviews

Description

Version 5.2.361.35 (cherry-pick) Merged 588e15c0343ba3052b15887f08a84bcd03f7e233 Merged c0d4bb89a1845bcc7a6d865e6c116d53514205ab [ia32] Fixes a bug in cmpw. [ia32] Fixes a wrong use of Operand in a test. BUG=621926 LOG=N R=mvstanton@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -7 lines)			Patch
M	include/v8-version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/disasm-ia32.cc	View	2 chunks	+17 lines, -4 lines	0 comments	Download
M	test/cctest/test-assembler-ia32.cc	View	1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125873002/1

4 years, 5 months ago (2016-07-06 13:26:12 UTC) #5

Message was sent while issue was closed.

CQ bit was unchecked.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages