OLD | NEW |
1 // Copyright 2011 the V8 project authors. All rights reserved. | 1 // Copyright 2011 the V8 project authors. All rights reserved. |
2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without |
3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are |
4 // met: | 4 // met: |
5 // | 5 // |
6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright |
7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. |
8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above |
9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following |
10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided |
(...skipping 1479 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
1490 code->Print(os); | 1490 code->Print(os); |
1491 #endif | 1491 #endif |
1492 F1 f = FUNCTION_CAST<F1>(code->entry()); | 1492 F1 f = FUNCTION_CAST<F1>(code->entry()); |
1493 for (int i = 0; i < kNumCases; ++i) { | 1493 for (int i = 0; i < kNumCases; ++i) { |
1494 int res = f(i); | 1494 int res = f(i); |
1495 ::printf("f(%d) = %d\n", i, res); | 1495 ::printf("f(%d) = %d\n", i, res); |
1496 CHECK_EQ(values[i], res); | 1496 CHECK_EQ(values[i], res); |
1497 } | 1497 } |
1498 } | 1498 } |
1499 | 1499 |
| 1500 TEST(Regress621926) { |
| 1501 // Bug description: |
| 1502 // The opcodes for cmpw r/m16, r16 and cmpw r16, r/m16 were swapped. |
| 1503 // This was causing non-commutative comparisons to produce the wrong result. |
| 1504 CcTest::InitializeVM(); |
| 1505 Isolate* isolate = reinterpret_cast<Isolate*>(CcTest::isolate()); |
| 1506 HandleScope scope(isolate); |
| 1507 Assembler assm(isolate, nullptr, 0); |
| 1508 |
| 1509 uint16_t a = 42; |
| 1510 |
| 1511 Label fail; |
| 1512 __ push(ebx); |
| 1513 __ mov(ebx, Immediate(reinterpret_cast<intptr_t>(&a))); |
| 1514 __ mov(eax, Immediate(41)); |
| 1515 __ cmpw(eax, Operand(ebx, 0)); |
| 1516 __ j(above_equal, &fail); |
| 1517 __ cmpw(Operand(ebx, 0), eax); |
| 1518 __ j(below_equal, &fail); |
| 1519 __ mov(eax, 1); |
| 1520 __ pop(ebx); |
| 1521 __ ret(0); |
| 1522 __ bind(&fail); |
| 1523 __ mov(eax, 0); |
| 1524 __ pop(ebx); |
| 1525 __ ret(0); |
| 1526 |
| 1527 CodeDesc desc; |
| 1528 assm.GetCode(&desc); |
| 1529 Handle<Code> code = isolate->factory()->NewCode( |
| 1530 desc, Code::ComputeFlags(Code::STUB), Handle<Code>()); |
| 1531 |
| 1532 #ifdef OBJECT_PRINT |
| 1533 OFStream os(stdout); |
| 1534 code->Print(os); |
| 1535 #endif |
| 1536 |
| 1537 F0 f = FUNCTION_CAST<F0>(code->entry()); |
| 1538 CHECK_EQ(f(), 1); |
| 1539 } |
| 1540 |
1500 #undef __ | 1541 #undef __ |
OLD | NEW |