Handle redirects to unresolved redirects

Handle redirects to unresolved redirects

The solves the handling of redirecting factories that redirects to other
redirecting factories whos immediate redirection target is unresolved.

For instance

  class C {
    factory C.a() = C.b;
    factory C.b() = Unresolved;
  }

The implementation normalizes the properties 'immediateRedirectionTarget',
'redirectionDeferredPrefix', 'effectiveTarget', 'effectiveTargetType', and
'isEffectiveTargetMalformed' by always storing the information on the
implementation element.

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/1f1e00f0126c2d62a893b87c1b649115c4e45974

[Johnni Winther, 2016-07-06 11:16:43]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-07-06 16:40:07]

lgtm

lgtm!
I really like this refactoring

https://codereview.chromium.org/2125823002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/2125823002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:412: throw new
UnsupportedError("setImmediateRedirectionTarget=");
nit: remove the '='

https://codereview.chromium.org/2125823002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:2307: if (isPatched) {
given how every method in this class has a different behavior if it is patched
or not, I wonder if it would be worth it to have a PatchedConstructorElementX
class...

https://codereview.chromium.org/2125823002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/resolution.dart (right):

https://codereview.chromium.org/2125823002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/resolution.dart:469: Element nextTarget =
target.immediateRedirectionTarget;
much cleaner!

https://codereview.chromium.org/2125823002/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization/equivalence_test.dart (right):

https://codereview.chromium.org/2125823002/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization/equivalence_test.dart:854: check(element1,
element2, 'messageKind', element1.messageKind, element2.messageKind);
dartfmt

[Johnni Winther, 2016-07-08 09:14:25]

Description was changed from

==========
Handle redirects to unresolved redirects

The solves the handling of redirecting factories that redirects to other
redirecting factories whos immediate redirection target is unresolved.

For instance

  class C {
    factory C.a() = C.b;
    factory C.b() = Unresolved;
  }

The implementation normalizes the properties 'immediateRedirectionTarget',
'redirectionDeferredPrefix', 'effectiveTarget', 'effectiveTargetType', and
'isEffectiveTargetMalformed' by always storing the information on the
implementation element.
==========

to

==========
Handle redirects to unresolved redirects

The solves the handling of redirecting factories that redirects to other
redirecting factories whos immediate redirection target is unresolved.

For instance

  class C {
    factory C.a() = C.b;
    factory C.b() = Unresolved;
  }

The implementation normalizes the properties 'immediateRedirectionTarget',
'redirectionDeferredPrefix', 'effectiveTarget', 'effectiveTargetType', and
'isEffectiveTargetMalformed' by always storing the information on the
implementation element.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1f1e00f0126c2d62a893b87c1b649115c4e45974
==========

[Johnni Winther, 2016-07-08 09:14:26]

Committed patchset #1 (id:1) manually as
1f1e00f0126c2d62a893b87c1b649115c4e45974 (presubmit successful).

[Johnni Winther, 2016-07-08 09:17:26]

https://codereview.chromium.org/2125823002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/2125823002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:412: throw new
UnsupportedError("setImmediateRedirectionTarget=");
On 2016/07/06 16:40:07, Harry Terkelsen wrote:
> nit: remove the '='

Done.

https://codereview.chromium.org/2125823002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:2307: if (isPatched) {
On 2016/07/06 16:40:07, Harry Terkelsen wrote:
> given how every method in this class has a different behavior if it is patched
> or not, I wonder if it would be worth it to have a PatchedConstructorElementX
> class...

Unfortunately we don't know if it is going to be patched at creation time :(

https://codereview.chromium.org/2125823002/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization/equivalence_test.dart (right):

https://codereview.chromium.org/2125823002/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization/equivalence_test.dart:854: check(element1,
element2, 'messageKind', element1.messageKind, element2.messageKind);
On 2016/07/06 16:40:07, Harry Terkelsen wrote:
> dartfmt

Really ?!? ;)