Handle redirects to unresolved redirects

tests/compiler/dart2js/serialization/equivalence_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.serialization_test;
 
 import 'dart:io';
 import '../memory_compiler.dart';
 import 'package:async_helper/async_helper.dart';
 import 'package:compiler/src/commandline_options.dart';
 import 'package:compiler/src/common.dart';
 import 'package:compiler/src/common/resolution.dart';
 import 'package:compiler/src/constants/constructors.dart';
 import 'package:compiler/src/compiler.dart';
 import 'package:compiler/src/diagnostics/invariant.dart';
 import 'package:compiler/src/elements/elements.dart';
 import 'package:compiler/src/elements/visitor.dart';
 import 'package:compiler/src/filenames.dart';
 import 'package:compiler/src/library_loader.dart';
 import 'package:compiler/src/ordered_typeset.dart';
 import 'package:compiler/src/serialization/element_serialization.dart';
 import 'package:compiler/src/serialization/equivalence.dart';
 import 'package:compiler/src/serialization/json_serializer.dart';
 import 'package:compiler/src/serialization/serialization.dart';
 import 'package:expect/expect.dart';
 import 'test_helper.dart';
 
 const TEST_SOURCES = const <String, String>{
   'main.dart': '''
-import 'a.dart' deferred as a;
+import 'deferred_library.dart' deferred as prefix;
 
 asyncMethod() async {}
 asyncStarMethod() async* {}
 syncStarMethod() sync* {}
 get asyncGetter async {}
 get asyncStarGetter async* {}
 get syncStarGetter sync* {}
 
 genericMethod<T>() {}
 
+class Class1 {
+  factory Class1.deferred() = prefix.DeferredClass;
+  factory Class1.unresolved() = Unresolved;
+}
 ''',
-  'a.dart': '''
+  'deferred_library.dart': '''
+class DeferredClass {
+}
 ''',
 };
 
 main(List<String> arguments) {
   // Ensure that we can print out constant expressions.
   DEBUG_MODE = true;
 
   Uri entryPoint;
   String outPath;
   bool prettyPrint = false;
@@ skipping 630 matching lines @@
       constantConstructorEquivalence(
           element1.constantConstructor,
           element2.constantConstructor);
     }
     check(element1, element2, 'isRedirectingGenerative',
         element1.isRedirectingGenerative, element2.isRedirectingGenerative);
     check(element1, element2, 'isRedirectingFactory',
         element1.isRedirectingFactory, element2.isRedirectingFactory);
     checkElementIdentities(element1, element2, 'effectiveTarget',
         element1.effectiveTarget, element2.effectiveTarget);
+    if (element1.isRedirectingFactory) {
+      checkElementIdentities(element1, element2, 'immediateRedirectionTarget',
+          element1.immediateRedirectionTarget,
+          element2.immediateRedirectionTarget);
+      checkElementIdentities(element1, element2, 'redirectionDeferredPrefix',
+          element1.redirectionDeferredPrefix,
+          element2.redirectionDeferredPrefix);
+      check(element1, element2, 'isEffectiveTargetMalformed',
+          element1.isEffectiveTargetMalformed,
+          element2.isEffectiveTargetMalformed);
+    }
     checkElementIdentities(element1, element2, 'definingConstructor',
         element1.definingConstructor, element2.definingConstructor);
     check(
         element1, element2, 'effectiveTargetType',
         element1.computeEffectiveTargetType(element1.enclosingClass.thisType),
         element2.computeEffectiveTargetType(element2.enclosingClass.thisType),
         areTypesEquivalent);
     check(
         element1, element2, 'effectiveTargetType.raw',
         element1.computeEffectiveTargetType(element1.enclosingClass.rawType),
@@ skipping 121 matching lines @@
         element1.isDeferred, element2.isDeferred);
     checkElementIdentities(
         element1, element2, 'deferredImport',
         element1.deferredImport, element2.deferredImport);
     if (element1.isDeferred) {
       checkElementProperties(element1, element2,
           'loadLibrary', element1.loadLibrary, element2.loadLibrary);
     }
     // TODO(johnniwinther): Check members.
   }
+
+  @override
+  void visitErroneousElement(ErroneousElement element1, ErroneousElement element2) {
+    check(element1, element2, 'messageKind', element1.messageKind, element2.messageKind);

[Harry Terkelsen, 2016/07/06 16:40:07]

dartfmt

[Johnni Winther, 2016/07/08 09:17:26]

Really ?!? ;)

+  }
 }