Issue 2125693003: Fix RenderedDocumentMarker::nullifyRenderedRect.

Issue 2125693003: Fix RenderedDocumentMarker::nullifyRenderedRect. (Closed)

Created:
4 years, 5 months ago by Alexander Semashko

Modified:
4 years, 5 months ago

Reviewers:
keishi

CC:
chromium-reviews, blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix RenderedDocumentMarker::nullifyRenderedRect. There obviously had to be assignment. Also I changed return types to be void since they're unused, and simplified updateMarkerRenderedRect a bit. Relevant CL: https://codereview.chromium.org/2034363002 R=keishi BUG= Committed: https://crrev.com/c0ac8b47882ec7b0643a6fb87e1746e28c34feb8 Cr-Commit-Position: refs/heads/master@{#403868}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
	M	third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp	View		2 chunks	+7 lines, -8 lines	0 comments	Download
	M	third_party/WebKit/Source/core/editing/markers/RenderedDocumentMarker.h	View		2 chunks	+8 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125693003/1

4 years, 5 months ago (2016-07-06 06:45:32 UTC) #4

commit-bot: I haz the power

4 years, 5 months ago (2016-07-06 08:40:02 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c0ac8b47882ec7b0643a6fb87e1746e28c34feb8
Cr-Commit-Position: refs/heads/master@{#403868}