Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: third_party/WebKit/Source/core/editing/markers/RenderedDocumentMarker.h

Issue 2125693003: Fix RenderedDocumentMarker::nullifyRenderedRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/markers/RenderedDocumentMarker.h
diff --git a/third_party/WebKit/Source/core/editing/markers/RenderedDocumentMarker.h b/third_party/WebKit/Source/core/editing/markers/RenderedDocumentMarker.h
index 8bda9a99b0f4060511662ad33c2f3e2524b13113..7c16845bf8009e9a46ad7189067ebbbbfd9df041 100644
--- a/third_party/WebKit/Source/core/editing/markers/RenderedDocumentMarker.h
+++ b/third_party/WebKit/Source/core/editing/markers/RenderedDocumentMarker.h
@@ -51,13 +51,12 @@ public:
DCHECK_EQ(m_state, State::ValidNotNull);
return m_renderedRect.contains(point);
}
- bool setRenderedRect(const LayoutRect& rect)
+ void setRenderedRect(const LayoutRect& rect)
{
if (m_state == State::ValidNotNull && rect == m_renderedRect)
- return false;
+ return;
m_state = State::ValidNotNull;
m_renderedRect = rect;
- return true;
}
const LayoutRect& renderedRect() const
@@ -66,7 +65,12 @@ public:
return m_renderedRect;
}
- bool nullifyRenderedRect() { return m_state == State::ValidNull; }
+ void nullifyRenderedRect()
+ {
+ m_state = State::ValidNull;
+ // Now |m_renderedRect| can not be accessed until |setRenderedRect| is
+ // called.
+ }
void invalidate() { m_state = State::Invalid; }
bool isValid() const { return m_state != State::Invalid; }
« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698