Chromium Code Reviews Chromium Code Reviews
Issue
2125673002:
Revert of Move all CARendererLayerTree parameters to separate struct. (Closed)
DescriptionRevert of Move all CARendererLayerTree parameters to separate struct. (patchset #7 id:120001 of https://codereview.chromium.org/2006923006/ )
Reason for revert:
Breaks https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_archive_rel_ng:
[21783/42386] OBJCXX obj/ui/accelerated_widget_mac/accelerated_widget_mac_unittests/ca_layer_tree_unittest_mac.o
FAILED: obj/ui/accelerated_widget_mac/accelerated_widget_mac_unittests/ca_layer_tree_unittest_mac.o
/b/build/slave/cache/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ui/accelerated_widget_mac/accelerated_widget_mac_unittests/ca_layer_tree_unittest_mac.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=274142-1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DGTEST_HAS_RTTI=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_MAC -DUNIT_TEST -DMESA_EGL_NO_X11_HEADERS -I../.. -Igen -I../../testing/gtest/include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../testing/gmock/include -I../../third_party/khronos -I../../gpu -I../../third_party/mesa/src/include -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -Wall -Werror -Wextra -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -O2 -gdwarf-2 -isysroot /Applications/Xcode7.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.7 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -Wheader-hygiene -Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-rtti -fno-exceptions -c ../../ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm -o obj/ui/accelerated_widget_mac/accelerated_widget_mac_unittests/ca_layer_tree_unittest_mac.o
../../ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm:40:31: error: too many arguments to function call, expected single argument 'params', have 12 arguments
properties->is_clipped, properties->clip_rect,
^~~~~~~~~~~~~~~~~~~~~~
../../ui/accelerated_widget_mac/ca_renderer_layer_tree.h:43:3: note: 'ScheduleCALayer' declared here
bool ScheduleCALayer(const CARendererLayerParams& params);
^
1 error generated.
You need to update this file: https://cs.chromium.org/chromium/src/ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm?rcl=0&l=39
Original issue's description:
> Move all CARendererLayerTree parameters to separate struct.
>
> Remove duplicate code.
>
> BUG=
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/565dd1451e49baa4d7e52b07d0c1cbd4cd2b92ab
> Cr-Commit-Position: refs/heads/master@{#403424}
TBR=ccameron@chromium.org,piman@chromium.org,thakis@chromium.org,kirr@yandex-team.ru
# Not skipping CQ checks because original CL landed more than 1 days ago.
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_archive_rel_ng
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
