Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 212563002: Revert of Ignore whitelist when generating android xml. (https://codereview.chromium.org/196923002/) (Closed)

Created:
6 years, 9 months ago by Jói
Modified:
6 years, 9 months ago
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Revert of Ignore whitelist when generating android xml. (https://codereview.chromium.org/196923002/) Reason for revert: This CL breaks the <if expr=""> for Android XML generation. Original issue's description: > Ignore whitelist when generating android xml. > > Whitelist should only apply to the resources used outside of Java. > This helps us to only need to specify the whitelist for C++ resources > without affecting Android XML file generation. > > BUG=338759 > > Patch from issue 196273004, landing for aurimas@chromium.org > > Committed: https://code.google.com/p/grit-i18n/source/detail?r=156 TBR=joi@chromium.org NOTREECHECKS=true NOTRY=true BUG=338759 Landing for aurimas@chromium.org, original patch at https://codereview.chromium.org/211743003/ Committed: https://code.google.com/p/grit-i18n/source/detail?r=157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M grit/format/android_xml.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Jói
Will land TBR.
6 years, 9 months ago (2014-03-26 09:56:59 UTC) #1
Jói
6 years, 9 months ago (2014-03-26 09:57:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r157 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698