Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: grit/format/android_xml.py

Issue 212563002: Revert of Ignore whitelist when generating android xml. (https://codereview.chromium.org/196923002/) (Closed) Base URL: https://grit-i18n.googlecode.com/svn/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: grit/format/android_xml.py
diff --git a/grit/format/android_xml.py b/grit/format/android_xml.py
index e835e9b9305a38d39b08d9bab7915e0be5f57a87..d960bf49ddb8f009575b36f3a146cd25edbef8f8 100644
--- a/grit/format/android_xml.py
+++ b/grit/format/android_xml.py
@@ -112,7 +112,7 @@ def Format(root, lang='en', output_dir='.'):
raise Exception('env variable ANDROID_JAVA_TAGGED_ONLY must have value '
'true or false. Invalid value: %s' % tagged_only)
- for item in root.Preorder():
+ for item in root.ActiveDescendants():
with item:
if ShouldOutputNode(item, tagged_only):
yield _FormatMessage(item, lang)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698