Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2125593002: [turbofan] Remove eager frame state from add and subtract. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove eager frame state from add and subtract. This removes the frame state input representing the before-state from nodes having the {JSAdd} or the {JSSubtract} operator. Lowering that inserts number conversions of the inputs has to be disabled when deoptimization is enabled, because the frame state layout is no longer known. R=jarin@chromium.org BUG=v8:5021 Committed: https://crrev.com/2620c4264af8988782267830a54b2601637ed97e Cr-Commit-Position: refs/heads/master@{#37522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -26 lines) Patch
M src/compiler/js-typed-lowering.cc View 3 chunks +14 lines, -5 lines 0 comments Download
M src/compiler/operator-properties.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 3 chunks +13 lines, -15 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-05 09:39:01 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-07-05 09:46:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125593002/1
4 years, 5 months ago (2016-07-05 10:42:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 10:45:22 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 10:46:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2620c4264af8988782267830a54b2601637ed97e
Cr-Commit-Position: refs/heads/master@{#37522}

Powered by Google App Engine
This is Rietveld 408576698