Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Issue 2121113002: [unittests] Remove spurious language mode test dimension. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-typed-lowering-3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[unittests] Remove spurious language mode test dimension. This just removes some left-overs from when the {JSTypedLoweringTest} covered strong mode and an iteration over all language modes was used for testing all binary operations. The language mode in question has been removed since then. R=bmeurer@chromium.org Committed: https://crrev.com/ee2d06e65fdb1b340b9181f1f1b03148f490476e Cr-Commit-Position: refs/heads/master@{#37526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -46 lines) Patch
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +39 lines, -46 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-05 09:51:25 UTC) #1
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-05 10:21:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121113002/1
4 years, 5 months ago (2016-07-05 11:47:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 12:07:36 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 12:10:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee2d06e65fdb1b340b9181f1f1b03148f490476e
Cr-Commit-Position: refs/heads/master@{#37526}

Powered by Google App Engine
This is Rietveld 408576698