Fix an assertion failure in HTMLTextAreaElement::subtreeHasChanged.

Fix an assertion failure in HTMLTextAreaElement::subtreeHasChanged.

Selection.deleteFromDocument() leaves an empty Text node in innerEditor of
TEXTAREA element, and InsertLineBreakCommand inserted a placeholder BR element
*before* the empty Text node.  It broke the assumption of TEXTAREA element.

This CL makes sure the BR element is appended at the last.

BUG=623547
Committed: https://crrev.com/3f6836d02c1cc98aec47ae8c1ff1e64522290403
Cr-Commit-Position: refs/heads/master@{#403853}

[tkent, 2016-07-05 08:40:27]

Description was changed from

==========
Fix an assertion failure in HTMLTextAreaElement::subtreeHasChanged.

Selection.deleteFromDocument() leaves an empty Text node in innerEditor of
TEXTAREA element, and InsertLineBreakCommand inserted a placeholder BR element
before the empty Text node.  It broke the assumption of TEXTAREA element.

This CL makes sure the BR element is appended at the last.

BUG=623547
==========

to

==========
Fix an assertion failure in HTMLTextAreaElement::subtreeHasChanged.

Selection.deleteFromDocument() leaves an empty Text node in innerEditor of
TEXTAREA element, and InsertLineBreakCommand inserted a placeholder BR element
*before* the empty Text node.  It broke the assumption of TEXTAREA element.

This CL makes sure the BR element is appended at the last.

BUG=623547
==========

[tkent, 2016-07-05 09:14:46]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-07-05 09:14:46]

yosin@, would you review this please?

[yosin_UTC9, 2016-07-06 01:10:24]

https://codereview.chromium.org/2125553002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-empty-textarea.html
(right):

https://codereview.chromium.org/2125553002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-empty-textarea.html:10:
document.querySelector('textarea').focus();
Can we use |assert_selection()|?
Samples:
https://cs.chromium.org/search/?q=assert_selection&sq=package:chromium&type=cs

assert_selection(
  '^<textarea>\ntext3 </textarea>|',
  selection => {
     selection.deleteFromDocument();
     selection.document.execCommand('insertText', false, '\n');
  },
  '<textarea>\n|</textarea>');

We would like to know shape of HTML and selection after surviving crash.

[tkent, 2016-07-06 03:52:52]

https://codereview.chromium.org/2125553002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-empty-textarea.html
(right):

https://codereview.chromium.org/2125553002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-empty-textarea.html:10:
document.querySelector('textarea').focus();
On 2016/07/06 at 01:10:24, Yosi_UTC9 wrote:
> Can we use |assert_selection()|?
> Samples:
https://cs.chromium.org/search/?q=assert_selection&sq=package:chromium&type=cs
> 
> assert_selection(
>   '^<textarea>\ntext3 </textarea>|',
>   selection => {
>      selection.deleteFromDocument();
>      selection.document.execCommand('insertText', false, '\n');
>   },
>   '<textarea>\n|</textarea>');
> 
> We would like to know shape of HTML and selection after surviving crash.

Unfortunately we can't use assert_selection() because the value of TEXTAREA
isn't stored as a child node of the TEXTAREA.

[yosin_UTC9, 2016-07-06 04:03:59]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-07-06 04:03:59]

lgtm

https://codereview.chromium.org/2125553002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-empty-textarea.html
(right):

https://codereview.chromium.org/2125553002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-empty-textarea.html:10:
document.querySelector('textarea').focus();
On 2016/07/06 at 03:52:52, tkent wrote:
> On 2016/07/06 at 01:10:24, Yosi_UTC9 wrote:
> > Can we use |assert_selection()|?
> > Samples:
https://cs.chromium.org/search/?q=assert_selection&sq=package:chromium&type=cs
> > 
> > assert_selection(
> >   '^<textarea>\ntext3 </textarea>|',
> >   selection => {
> >      selection.deleteFromDocument();
> >      selection.document.execCommand('insertText', false, '\n');
> >   },
> >   '<textarea>\n|</textarea>');
> > 
> > We would like to know shape of HTML and selection after surviving crash.
> 
> Unfortunately we can't use assert_selection() because the value of TEXTAREA
isn't stored as a child node of the TEXTAREA.

Oh, OK.

[commit-bot: I haz the power, 2016-07-06 04:04:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 05:21:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-06 05:23:21]

Description was changed from

==========
Fix an assertion failure in HTMLTextAreaElement::subtreeHasChanged.

Selection.deleteFromDocument() leaves an empty Text node in innerEditor of
TEXTAREA element, and InsertLineBreakCommand inserted a placeholder BR element
*before* the empty Text node.  It broke the assumption of TEXTAREA element.

This CL makes sure the BR element is appended at the last.

BUG=623547
==========

to

==========
Fix an assertion failure in HTMLTextAreaElement::subtreeHasChanged.

Selection.deleteFromDocument() leaves an empty Text node in innerEditor of
TEXTAREA element, and InsertLineBreakCommand inserted a placeholder BR element
*before* the empty Text node.  It broke the assumption of TEXTAREA element.

This CL makes sure the BR element is appended at the last.

BUG=623547

Committed: https://crrev.com/3f6836d02c1cc98aec47ae8c1ff1e64522290403
Cr-Commit-Position: refs/heads/master@{#403853}
==========

[commit-bot: I haz the power, 2016-07-06 05:23:22]

Patchset 1 (id:??) landed as
https://crrev.com/3f6836d02c1cc98aec47ae8c1ff1e64522290403
Cr-Commit-Position: refs/heads/master@{#403853}