third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-empty-textarea.html - Issue 2125553002: Fix an assertion failure in HTMLTextAreaElement::subtreeHasChanged.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/inserting/insert-paragraph-empty-textarea.html

Issue 2125553002: Fix an assertion failure in HTMLTextAreaElement::subtreeHasChanged. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <textarea>

	6 text3

	7 </textarea>

	8 <script>

	9 test(() => {

	10 document.querySelector('textarea').focus();
	yosin_UTC9 2016/07/06 01:10:24 Can we use \|assert_selection()\|? Samples: https:// Can we use \|assert_selection()\|? Samples: https://cs.chromium.org/search/?q=assert_selection&sq=package:chromium&type=cs assert_selection( '^<textarea>\ntext3 </textarea>\|', selection => { selection.deleteFromDocument(); selection.document.execCommand('insertText', false, '\n'); }, '<textarea>\n\|</textarea>'); We would like to know shape of HTML and selection after surviving crash. tkent 2016/07/06 03:52:52 Unfortunately we can't use assert_selection() beca Show quoted text On 2016/07/06 at 01:10:24, Yosi_UTC9 wrote: > Can we use \|assert_selection()\|? > Samples: https://cs.chromium.org/search/?q=assert_selection&sq=package:chromium&type=cs > > assert_selection( > '^<textarea>\ntext3 </textarea>\|', > selection => { > selection.deleteFromDocument(); > selection.document.execCommand('insertText', false, '\n'); > }, > '<textarea>\n\|</textarea>'); > > We would like to know shape of HTML and selection after surviving crash. Unfortunately we can't use assert_selection() because the value of TEXTAREA isn't stored as a child node of the TEXTAREA. yosin_UTC9 2016/07/06 04:03:59 Oh, OK. Show quoted text On 2016/07/06 at 03:52:52, tkent wrote: > On 2016/07/06 at 01:10:24, Yosi_UTC9 wrote: > > Can we use \|assert_selection()\|? > > Samples: https://cs.chromium.org/search/?q=assert_selection&sq=package:chromium&type=cs > > > > assert_selection( > > '^<textarea>\ntext3 </textarea>\|', > > selection => { > > selection.deleteFromDocument(); > > selection.document.execCommand('insertText', false, '\n'); > > }, > > '<textarea>\n\|</textarea>'); > > > > We would like to know shape of HTML and selection after surviving crash. > > Unfortunately we can't use assert_selection() because the value of TEXTAREA isn't stored as a child node of the TEXTAREA. Oh, OK.
	11 document.execCommand('selectAll');

	12 selection = document.getSelection();

	13 selection.deleteFromDocument();

	14 document.execCommand('InsertText', false, '\n');

	15 }, 'A combination of deleteFromDocument() and InsertText command should not caus e check failure in HTMLTextAreaElement.');

	16 </script>

	17 </body>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp » ('j') | no next file with comments »