Remove WebKit version from the About page on Chrome OS and the Blink version from chrome://version.

Remove WebKit version from the About page on Chrome OS and the Blink version from chrome://version.

The former is misleading; Chromium hasn't used WebKit for over three years.

The Blink version no longer adds more information. Since the repository merge,
the Blink version number is a constant 537.36 and its revision always matches the
Chromium revision.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/fe66a859b6dbec85510b6242dd65b73a910d2030
Cr-Commit-Position: refs/heads/master@{#405995}

[jbroman, 2016-07-04 16:00:12]

Description was changed from

==========
Remove WebKit version from the About page on Chrome OS.

This is misleading (we haven't used WebKit for over two years), and useless
(we haven't updated the WebKit version since then).
==========

to

==========
Remove WebKit version from the About page on Chrome OS.

This is misleading (we haven't used WebKit for over two years), and useless
(we haven't updated the WebKit version since then).
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[jbroman, 2016-07-04 16:01:17]

Description was changed from

==========
Remove WebKit version from the About page on Chrome OS.

This is misleading (we haven't used WebKit for over two years), and useless
(we haven't updated the WebKit version since then).
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove WebKit version from the About page on Chrome OS.

This is misleading (we haven't used WebKit for over two years), and useless
(we haven't updated the WebKit version since then).

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[jbroman, 2016-07-04 17:33:05]

jbroman@chromium.org changed reviewers:
+ dbeam@chromium.org

[jbroman, 2016-07-04 17:33:05]

This doesn't seem useful to show under the "More Info" section anymore. WDYT?

[jbroman, 2016-07-04 17:35:07]

Description was changed from

==========
Remove WebKit version from the About page on Chrome OS.

This is misleading (we haven't used WebKit for over two years), and useless
(we haven't updated the WebKit version since then).

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove WebKit version from the About page on Chrome OS.

This is misleading (we haven't used WebKit for over two years), and useless
(we haven't updated the WebKit version number since then).

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[jbroman, 2016-07-04 17:35:19]

Description was changed from

==========
Remove WebKit version from the About page on Chrome OS.

This is misleading (we haven't used WebKit for over two years), and useless
(we haven't updated the WebKit version number since then).

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove WebKit version from the About page on Chrome OS.

This is misleading (we haven't used WebKit for over two years) and useless
(we haven't updated the WebKit version number since then).

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-07-06 18:26:52]

https://codereview.chromium.org/2125473002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/help/help_handler.cc (left):

https://codereview.chromium.org/2125473002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_handler.cc:381:
localized_strings->SetString("webkitVersion", content::GetWebKitVersion());
the number stays the same but the sha1 doesn't, i.e

Google Chrome	51.0.2704.106 (Official Build) (64-bit)
Blink	537.36 (@27e9e15b411edc75a2233a9ad11dc7ae86e243fd)

Chromium	54.0.2786.0 (Developer Build) (64-bit)
Blink	537.36 (@35a900e3ee8f2bf93654621eb24914c5eb07fd95)

we also show this info on about:version.

are you proposing that the info isn't useful:
a) anywhere
b) just this page?
c) it is useful if there's a sha1

[jbroman, 2016-07-06 18:36:31]

On 2016/07/06 at 18:26:52, dbeam wrote:
>
https://codereview.chromium.org/2125473002/diff/20001/chrome/browser/ui/webui...
> File chrome/browser/ui/webui/help/help_handler.cc (left):
> 
>
https://codereview.chromium.org/2125473002/diff/20001/chrome/browser/ui/webui...
> chrome/browser/ui/webui/help/help_handler.cc:381:
localized_strings->SetString("webkitVersion", content::GetWebKitVersion());
> the number stays the same but the sha1 doesn't, i.e
> 
> Google Chrome	51.0.2704.106 (Official Build) (64-bit)
> Blink	537.36 (@27e9e15b411edc75a2233a9ad11dc7ae86e243fd)
> 
> Chromium	54.0.2786.0 (Developer Build) (64-bit)
> Blink	537.36 (@35a900e3ee8f2bf93654621eb24914c5eb07fd95)

Interesting; this shows "537.36 (@0)" for me on 52.0.2743.57 beta (samus).

> we also show this info on about:version.

I wasn't aware of that. I also see "0" there for both Revision and the Blink
revision.

> are you proposing that the info isn't useful:
> a) anywhere
> b) just this page?
> c) it is useful if there's a sha1

Slightly more useful if there's a SHA-1, but if we do want the SHA-1 it's not
meaningful to attribute it to Blink, as it's actually the SHA-1 of the Chromium
repository. There is no remaining distinction between Chromium and Blink
versions.

[jbroman, 2016-07-13 19:09:26]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 19:10:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-07-13 19:11:31]

Description was changed from

==========
Remove WebKit version from the About page on Chrome OS.

This is misleading (we haven't used WebKit for over two years) and useless
(we haven't updated the WebKit version number since then).

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove WebKit version from the About page on Chrome OS and the Blink version
from chrome://version.

The former is misleading; Chromium hasn't used WebKit for over three years.

The Blink version no longer adds more information. Since the repository merge,
the Blink version number is a constant and its revision always matches the
Chromium revision.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[jbroman, 2016-07-13 19:11:58]

Description was changed from

==========
Remove WebKit version from the About page on Chrome OS and the Blink version
from chrome://version.

The former is misleading; Chromium hasn't used WebKit for over three years.

The Blink version no longer adds more information. Since the repository merge,
the Blink version number is a constant and its revision always matches the
Chromium revision.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove WebKit version from the About page on Chrome OS and the Blink version
from chrome://version.

The former is misleading; Chromium hasn't used WebKit for over three years.

The Blink version no longer adds more information. Since the repository merge,
the Blink version number is a constant 537.36 and its revision always matches
the
Chromium revision.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[jbroman, 2016-07-13 19:17:59]

The chrome://version page at least showed "Blink", but beyond mentioning Blink
it doesn't say anything that the fields above don't.

Google Chrome	51.0.2704.106 (Official Build) (64-bit)
Revision	27e9e15b411edc75a2233a9ad11dc7ae86e243fd-refs/branch-heads/2704_103@{#3}
Blink	537.36 (@27e9e15b411edc75a2233a9ad11dc7ae86e243fd)

^ 537.36 hasn't changed in years, and 27e9e15b411edc75a2233a9ad11dc7ae86e243fd
is mentioned above

Given that, it sounds like we can simplify chrome://version as well, unless we
want to keep the string "Blink" on that page somewhere (done in the last patch
set, but I don't feel strongly).

[commit-bot: I haz the power, 2016-07-13 19:33:25]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names without "master." prefix is deprecated:
tryserver.chromium.linux. For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-13 20:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 20:10:56]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-07-18 04:59:11]

aight, let's give this a shot

lgtm

[jbroman, 2016-07-18 14:30:05]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-07-18 14:30:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 14:30:36]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-18 15:20:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-18 15:20:42]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 15:21:25]

Description was changed from

==========
Remove WebKit version from the About page on Chrome OS and the Blink version
from chrome://version.

The former is misleading; Chromium hasn't used WebKit for over three years.

The Blink version no longer adds more information. Since the repository merge,
the Blink version number is a constant 537.36 and its revision always matches
the
Chromium revision.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove WebKit version from the About page on Chrome OS and the Blink version
from chrome://version.

The former is misleading; Chromium hasn't used WebKit for over three years.

The Blink version no longer adds more information. Since the repository merge,
the Blink version number is a constant 537.36 and its revision always matches
the
Chromium revision.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/fe66a859b6dbec85510b6242dd65b73a910d2030
Cr-Commit-Position: refs/heads/master@{#405995}
==========

[commit-bot: I haz the power, 2016-07-18 15:21:26]

Patchset 3 (id:??) landed as
https://crrev.com/fe66a859b6dbec85510b6242dd65b73a910d2030
Cr-Commit-Position: refs/heads/master@{#405995}