Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: chrome/browser/ui/webui/version_ui.cc

Issue 2125473002: Remove WebKit version from the About page on Chrome OS and the Blink version from chrome://version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove from chrome://version, too. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/version_ui.h" 5 #include "chrome/browser/ui/webui/version_ui.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/i18n/message_formatter.h" 8 #include "base/i18n/message_formatter.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 html_source->AddLocalizedString(version_ui::kApplicationLabel, 55 html_source->AddLocalizedString(version_ui::kApplicationLabel,
56 IDS_PRODUCT_NAME); 56 IDS_PRODUCT_NAME);
57 html_source->AddString(version_ui::kVersion, 57 html_source->AddString(version_ui::kVersion,
58 version_info::GetVersionNumber()); 58 version_info::GetVersionNumber());
59 html_source->AddString(version_ui::kVersionModifier, 59 html_source->AddString(version_ui::kVersionModifier,
60 chrome::GetChannelString()); 60 chrome::GetChannelString());
61 html_source->AddLocalizedString(version_ui::kOSName, IDS_VERSION_UI_OS); 61 html_source->AddLocalizedString(version_ui::kOSName, IDS_VERSION_UI_OS);
62 html_source->AddLocalizedString(version_ui::kARC, IDS_ARC_LABEL); 62 html_source->AddLocalizedString(version_ui::kARC, IDS_ARC_LABEL);
63 html_source->AddLocalizedString(version_ui::kPlatform, IDS_PLATFORM_LABEL); 63 html_source->AddLocalizedString(version_ui::kPlatform, IDS_PLATFORM_LABEL);
64 html_source->AddString(version_ui::kOSType, version_info::GetOSType()); 64 html_source->AddString(version_ui::kOSType, version_info::GetOSType());
65 html_source->AddString(version_ui::kBlinkVersion,
66 content::GetWebKitVersion());
67 html_source->AddString(version_ui::kJSEngine, "V8"); 65 html_source->AddString(version_ui::kJSEngine, "V8");
68 html_source->AddString(version_ui::kJSVersion, v8::V8::GetVersion()); 66 html_source->AddString(version_ui::kJSVersion, v8::V8::GetVersion());
69 67
70 #if defined(OS_ANDROID) 68 #if defined(OS_ANDROID)
71 html_source->AddString(version_ui::kOSVersion, 69 html_source->AddString(version_ui::kOSVersion,
72 AndroidAboutAppInfo::GetOsInfo()); 70 AndroidAboutAppInfo::GetOsInfo());
73 #else 71 #else
74 html_source->AddString(version_ui::kOSVersion, std::string()); 72 html_source->AddString(version_ui::kOSVersion, std::string());
75 html_source->AddString(version_ui::kFlashPlugin, "Flash"); 73 html_source->AddString(version_ui::kFlashPlugin, "Flash");
76 // Note that the Flash version is retrieve asynchronously and returned in 74 // Note that the Flash version is retrieve asynchronously and returned in
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 // Set up the chrome://theme/ source. 170 // Set up the chrome://theme/ source.
173 ThemeSource* theme = new ThemeSource(profile); 171 ThemeSource* theme = new ThemeSource(profile);
174 content::URLDataSource::Add(profile, theme); 172 content::URLDataSource::Add(profile, theme);
175 #endif 173 #endif
176 174
177 WebUIDataSource::Add(profile, CreateVersionUIDataSource()); 175 WebUIDataSource::Add(profile, CreateVersionUIDataSource());
178 } 176 }
179 177
180 VersionUI::~VersionUI() { 178 VersionUI::~VersionUI() {
181 } 179 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/help/help_handler.cc ('k') | components/version_ui/resources/about_version.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698