net/url_request/url_request_redirect_job.cc - Issue 212543005: Do not copy reference fragments for overridden redirects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_redirect_job.cc

Issue 212543005: Do not copy reference fragments for overridden redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add URLRequestJob::IsRedirectFragmentModificationAllowed Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/url_request/url_request_job.h ('K') | « net/url_request/url_request_redirect_job.h ('k') | net/url_request/url_request_unittest.cc » ('j') | net/url_request/url_request_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_redirect_job.cc

diff --git a/net/url_request/url_request_redirect_job.cc b/net/url_request/url_request_redirect_job.cc

index c9d30aebedd432612dcd0ee1b839a181d485cfc6..644fcf6625857452d939cfdf525800a943588463 100644

--- a/net/url_request/url_request_redirect_job.cc

+++ b/net/url_request/url_request_redirect_job.cc

@@ -44,6 +44,13 @@ bool URLRequestRedirectJob::IsRedirectResponse(GURL* location,

return true;

}

+bool URLRequestRedirectJob::IsRedirectFragmentModificationAllowed(

+ const GURL& location) {

+ // The instantiators have full control over the desired redirection target,

+ // including the reference fragment part of the URL.

mmenke 2014/03/31 20:45:49 This behavior should be documented in NetworkDeleg

robwu 2014/04/01 16:09:33 Done.

+ return false;

URLRequestRedirectJob::~URLRequestRedirectJob() {}

void URLRequestRedirectJob::StartAsync() {

« net/url_request/url_request_job.h ('K') | « net/url_request/url_request_redirect_job.h ('k') | net/url_request/url_request_unittest.cc » ('j') | net/url_request/url_request_unittest.cc » ('J')