net/url_request/url_request_job.h - Issue 212543005: Do not copy reference fragments for overridden redirects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_job.h

Issue 212543005: Do not copy reference fragments for overridden redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add URLRequestJob::IsRedirectFragmentModificationAllowed Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/url_request/url_request_http_job.cc ('K') | « net/url_request/url_request_http_job.cc ('k') | net/url_request/url_request_job.cc » ('j') | net/url_request/url_request_redirect_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_job.h

diff --git a/net/url_request/url_request_job.h b/net/url_request/url_request_job.h

index c6f7ba4e4bab705cc7cfd9e2b0527cc72363fd4c..b29be801eb38ea5700c39bf710987679f6e89914 100644

--- a/net/url_request/url_request_job.h

+++ b/net/url_request/url_request_job.h

@@ -157,6 +157,14 @@ class NET_EXPORT URLRequestJob

// The default implementation inspects the response_info_.

virtual bool IsRedirectResponse(GURL* location, int* http_status_code);

+ // Called to determine if it is okay to copy the reference fragment from the

+ // original URL to the redirection target when the redirection target has no

+ // reference fragment.

+ //

+ // The default implementation returns true.

+ virtual bool IsRedirectFragmentModificationAllowed(

+ const GURL& location) OVERRIDE;

mmenke 2014/03/31 20:45:49 nit: const

robwu 2014/04/01 16:09:33 Done.

// Called to determine if it is okay to redirect this job to the specified

// location. This may be used to implement protocol-specific restrictions.

// If this function returns false, then the URLRequest will fail