runtime/bin/vmservice/vmservice_io.dart - Issue 2125343002: Ban cross origin WebSocket connections to the service protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/vmservice_io.dart

Issue 2125343002: Ban cross origin WebSocket connections to the service protocol (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: skybrian review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice/vmservice_io.dart

diff --git a/runtime/bin/vmservice/vmservice_io.dart b/runtime/bin/vmservice/vmservice_io.dart

index ba2b27701501b054cd2d156bc63c45886bd8d9b4..47535494c922d1b3468d5128110cd8fb34d2ffd5 100644

--- a/runtime/bin/vmservice/vmservice_io.dart

+++ b/runtime/bin/vmservice/vmservice_io.dart

@@ -19,7 +19,8 @@ int _port;

String _ip;

// Should the HTTP server auto start?

bool _autoStart;

+// Should the HTTP server run in devmode?

+bool _originCheckDisabled;

bool _isWindows = false;

var _signalWatch;

var _signalSubscription;

@@ -35,7 +36,7 @@ _lazyServerBoot() {

// Lazily create service.

var service = new VMService();

// Lazily create server.

- server = new Server(service, _ip, _port);

+ server = new Server(service, _ip, _port, _originCheckDisabled);

}

Future cleanupCallback() async {

« no previous file with comments | « runtime/bin/vmservice/server.dart ('k') | runtime/bin/vmservice_impl.h » ('j') | no next file with comments »