runtime/bin/vmservice_impl.h - Issue 2125343002: Ban cross origin WebSocket connections to the service protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice_impl.h

Issue 2125343002: Ban cross origin WebSocket connections to the service protocol (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: skybrian review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice_impl.h

diff --git a/runtime/bin/vmservice_impl.h b/runtime/bin/vmservice_impl.h

index f373b4beb3a4c4ff9a8372c2aab714a2308b1641..f499abfd41b67abea619ff086e0d49a19fdb205e 100644

--- a/runtime/bin/vmservice_impl.h

+++ b/runtime/bin/vmservice_impl.h

@@ -18,7 +18,8 @@ class VmService {

static bool Setup(const char* server_ip,

intptr_t server_port,

- bool running_precompiled);

+ bool running_precompiled,

+ bool dev_mode_server);

// Error message if startup failed.

static const char* GetErrorMessage();

« no previous file with comments | « runtime/bin/vmservice/vmservice_io.dart ('k') | runtime/bin/vmservice_impl.cc » ('j') | no next file with comments »