Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2125223003: gyp: don't build gamepad_platform_data_fetcher_linux.cc when udev is disabled (Closed)

Created:
4 years, 5 months ago by Mostyn Bramley-Moore
Modified:
4 years, 5 months ago
Reviewers:
bajones
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gyp: don't build gamepad_platform_data_fetcher_linux.cc when udev is disabled Fixup after https://codereview.chromium.org/2081583002 BUG=612330 Committed: https://crrev.com/3fd0432005a1a370ed273077aec593acd1aa963c Cr-Commit-Position: refs/heads/master@{#404168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M device/gamepad/gamepad.gyp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125223003/1
4 years, 5 months ago (2016-07-07 07:24:55 UTC) #2
Mostyn Bramley-Moore
4 years, 5 months ago (2016-07-07 07:25:27 UTC) #4
Mostyn Bramley-Moore
@bajones: please take a look at this small fixup after https://codereview.chromium.org/2081583002 - without this, non-udev ...
4 years, 5 months ago (2016-07-07 07:26:16 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 08:08:08 UTC) #7
bajones
On 2016/07/07 08:08:08, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 5 months ago (2016-07-07 15:33:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125223003/1
4 years, 5 months ago (2016-07-07 16:04:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 17:39:42 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 17:41:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3fd0432005a1a370ed273077aec593acd1aa963c
Cr-Commit-Position: refs/heads/master@{#404168}

Powered by Google App Engine
This is Rietveld 408576698