[IndexedDB] Propogating changes to observers : Renderer

content/browser/indexed_db/indexed_db_connection.h

Index: content/browser/indexed_db/indexed_db_connection.h
diff --git a/content/browser/indexed_db/indexed_db_connection.h b/content/browser/indexed_db/indexed_db_connection.h
index 3c305f39d057147c8a8feb12654a0f826404b09a..fd5ee7bc3b2fd68580ed6d46236111312d315eed 100644
--- a/content/browser/indexed_db/indexed_db_connection.h
+++ b/content/browser/indexed_db/indexed_db_connection.h
@@ -35,6 +35,9 @@ class CONTENT_EXPORT IndexedDBConnection {
   // connection.
   virtual void RemoveObservers(const std::vector<int32_t>& remove_observer_ids);
 
+  void set_id(int32_t id);
+  int32_t id() const { return id_; }
+
   IndexedDBDatabase* database() const { return database_.get(); }
   IndexedDBDatabaseCallbacks* callbacks() const { return callbacks_.get(); }
   const std::vector<std::unique_ptr<IndexedDBObserver>>& active_observers()
@@ -46,9 +49,11 @@ class CONTENT_EXPORT IndexedDBConnection {
   }
 
  private:
+  enum { kInvalidId = -1 };
+  int32_t id_ = kInvalidId; /* ipc_database_id */

[jsbell, 2016/07/14 20:08:13]

Match the surrounding comment style (// on preceding lines)

Also, 'ipc_database_id' is poorly named inside IndexedDBDispatcherHost::Add - a
better description would be idb_connection_id. (It's just that a connection is
called 'IDBDatabase' on the blink side, to match script/spec)

[palakj1, 2016/07/15 20:16:04]

Do you mean we should rename all 'ipc_database_id' to idb_connection_id or just
within IndexedDBDispatcherHost::Add? 

+
   // NULL in some unit tests, and after the connection is closed.
   scoped_refptr<IndexedDBDatabase> database_;
-
   // The callbacks_ member is cleared when the connection is closed.
   // May be NULL in unit tests.
   scoped_refptr<IndexedDBDatabaseCallbacks> callbacks_;