[IndexedDB] Propogating changes to observers : Renderer

content/browser/indexed_db/indexed_db_connection.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CONNECTION_H_
 #define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CONNECTION_H_
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 17 matching lines @@
 
   void VersionChangeIgnored();
 
   virtual void ActivatePendingObservers(
       std::vector<std::unique_ptr<IndexedDBObserver>> pending_observers);
   // Removes observer listed in |remove_observer_ids| from active_observer of
   // connection or pending_observer of transactions associated with this
   // connection.
   virtual void RemoveObservers(const std::vector<int32_t>& remove_observer_ids);
 
+  void set_id(int32_t id);
+  int32_t id() const { return id_; }
+
   IndexedDBDatabase* database() const { return database_.get(); }
   IndexedDBDatabaseCallbacks* callbacks() const { return callbacks_.get(); }
   const std::vector<std::unique_ptr<IndexedDBObserver>>& active_observers()
       const {
     return active_observers_;
   }
   base::WeakPtr<IndexedDBConnection> GetWeakPtr() {
     return weak_factory_.GetWeakPtr();
   }
 
  private:
+  enum { kInvalidId = -1 };
+  int32_t id_ = kInvalidId; /* ipc_database_id */

[jsbell, 2016/07/14 20:08:13]

Match the surrounding comment style (// on preceding lines)

Also, 'ipc_database_id' is poorly named inside IndexedDBDispatcherHost::Add - a
better description would be idb_connection_id. (It's just that a connection is
called 'IDBDatabase' on the blink side, to match script/spec)

[palakj1, 2016/07/15 20:16:04]

Do you mean we should rename all 'ipc_database_id' to idb_connection_id or just
within IndexedDBDispatcherHost::Add? 

+
   // NULL in some unit tests, and after the connection is closed.
   scoped_refptr<IndexedDBDatabase> database_;
-
   // The callbacks_ member is cleared when the connection is closed.
   // May be NULL in unit tests.
   scoped_refptr<IndexedDBDatabaseCallbacks> callbacks_;
   std::vector<std::unique_ptr<IndexedDBObserver>> active_observers_;
   base::WeakPtrFactory<IndexedDBConnection> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(IndexedDBConnection);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_CONNECTION_H_