third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h - Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime

Patch Set: IDBDatabase weakptr introduced on IDBObserver Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.idl ('K') | « third_party/WebKit/public/blink_headers.gypi ('k') | third_party/WebKit/public/platform/modules/indexeddb/WebIDBKeyRange.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

diff --git a/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h b/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

index d4e80d2b5cdb5d784a13c3c67402c1176f30f26d..3e103b0ae73bb1ca995946ed7514cc19c782c6a4 100644

--- a/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

+++ b/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

@@ -66,7 +66,6 @@ public:

typedef WebVector<WebIDBKey> WebIndexKeys;

virtual int32_t addObserver(std::unique_ptr<WebIDBObserver>, long long transactionId) = 0;

- virtual bool containsObserverId(int32_t id) const = 0;

virtual void removeObservers(const std::vector<int32_t>& observerIdsToRemove) = 0;

virtual void get(long long transactionId, long long objectStoreId, long long indexId, const WebIDBKeyRange&, bool keyOnly, WebIDBCallbacks*) = 0;

virtual void getAll(long long transactionId, long long objectStoreId, long long indexId, const WebIDBKeyRange&, long long maxCount, bool keyOnly, WebIDBCallbacks*) = 0;