Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2125163003:
Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" (Closed)
|
Created:
4 years, 5 months ago by emircan Modified:
4 years, 5 months ago CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available"
This CL relands the below patch to enable HW H264 encoding on
every supported platform.
It was originally reverted while fixing ChromeOS issues listed
below. Kernel fixes for these have landed.
https://bugs.chromium.org/p/chromium/issues/detail?id=615272
https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3
BUG=611574, 625073
TEST=Test AppRTC loopback on
https://apprtc.appspot.com/?debug=loopback&vsc=h264
with flag enable-webrtc-h264-with-openh264-ffmpeg enabled.
Original CL description:
https://codereview.chromium.org/1972333002
Use kEnableWebRtcHWH264Encoding flag when SW fallback is available
HW H264 encoding was only enabled on extensions so far through
the use of kEnableWebRtcHWH264Encoding flag. This CL attaches
kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg
is available. As a result, HW H264 encoding would be enabled on
every supported platform where SW H264 fallback is also available.
Committed: https://crrev.com/ffaecc8ff3be5cdd883e5a51b19acc04cb40a4b4
Cr-Commit-Position: refs/heads/master@{#404184}
Patch Set 1 : #
Messages
Total messages: 24 (15 generated)
remcovanvugt84@gmail.com changed reviewers: + RemcovanVugt84@gmail.com, remcovanvugt84@gmail.com
lgtm
Description was changed from ========== reen BUG= ========== to ========== reen BUG= ==========
emircan@chromium.org changed reviewers: - RemcovanVugt84@gmail.com, remcovanvugt84@gmail.com
Patchset #1 (id:1) has been deleted
Description was changed from ========== reen BUG= ========== to ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 Original CL description: Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
emircan@chromium.org changed reviewers: + wuchengli@chromium.org
PTAL. Note: Ignore the spammer above.
Description was changed from ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 Original CL description: Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. ========== to ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 Original CL description: https://codereview.chromium.org/1972333002 Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. ==========
Description was changed from ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 Original CL description: https://codereview.chromium.org/1972333002 Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. ========== to ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 Original CL description: https://codereview.chromium.org/1972333002 Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. ==========
On 2016/07/06 23:53:11, emircan wrote: > PTAL. > > Note: Ignore the spammer above. I took a look at https://crrev.com/1972333002 and this CL did not seem a verbatim reland: in that case, just remove the "reland" references, or make PS1 be the relanded CL _verbatim_ and add your diffs in PS2 and subsequent. Also, please add a line with TEST= indicating how this new code can be exercised (e.g., use appr.tc/loopback with flag chrome://flags/#enable-webrtc-h264-with-openh264-ffmpeg active).
lgtm
Description was changed from ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 Original CL description: https://codereview.chromium.org/1972333002 Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. ========== to ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 TEST= on https://apprtc.appspot.com/?debug=loopback&vsc=h264 Original CL description: https://codereview.chromium.org/1972333002 Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. ==========
Description was changed from ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 TEST= on https://apprtc.appspot.com/?debug=loopback&vsc=h264 Original CL description: https://codereview.chromium.org/1972333002 Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. ========== to ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 TEST=Test AppRTC loopback on https://apprtc.appspot.com/?debug=loopback&vsc=h264 with flag enable-webrtc-h264-with-openh264-ffmpeg enabled. Original CL description: https://codereview.chromium.org/1972333002 Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. ==========
On 2016/07/07 00:16:38, mcasas wrote: > I took a look at https://crrev.com/1972333002 and this CL did > not seem a verbatim reland: in that case, just remove the "reland" > references, or make PS1 be the relanded CL _verbatim_ and > add your diffs in PS2 and subsequent. > > Also, please add a line with TEST= indicating how this > new code can be exercised (e.g., use appr.tc/loopback with > flag chrome://flags/#enable-webrtc-h264-with-openh264-ffmpeg > active). I added the TEST line. Direct revert failed to apply as the folders moved. It is the exact same changes on the code, and additional comments as I realized there were confusions about the flag usage earlier.
The CQ bit was checked by emircan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from RemcovanVugt84@gmail.com Link to the patchset: https://codereview.chromium.org/2125163003/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 TEST=Test AppRTC loopback on https://apprtc.appspot.com/?debug=loopback&vsc=h264 with flag enable-webrtc-h264-with-openh264-ffmpeg enabled. Original CL description: https://codereview.chromium.org/1972333002 Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. ========== to ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 TEST=Test AppRTC loopback on https://apprtc.appspot.com/?debug=loopback&vsc=h264 with flag enable-webrtc-h264-with-openh264-ffmpeg enabled. Original CL description: https://codereview.chromium.org/1972333002 Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 TEST=Test AppRTC loopback on https://apprtc.appspot.com/?debug=loopback&vsc=h264 with flag enable-webrtc-h264-with-openh264-ffmpeg enabled. Original CL description: https://codereview.chromium.org/1972333002 Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. ========== to ========== Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This CL relands the below patch to enable HW H264 encoding on every supported platform. It was originally reverted while fixing ChromeOS issues listed below. Kernel fixes for these have landed. https://bugs.chromium.org/p/chromium/issues/detail?id=615272 https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3 BUG=611574,625073 TEST=Test AppRTC loopback on https://apprtc.appspot.com/?debug=loopback&vsc=h264 with flag enable-webrtc-h264-with-openh264-ffmpeg enabled. Original CL description: https://codereview.chromium.org/1972333002 Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. Committed: https://crrev.com/ffaecc8ff3be5cdd883e5a51b19acc04cb40a4b4 Cr-Commit-Position: refs/heads/master@{#404184} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ffaecc8ff3be5cdd883e5a51b19acc04cb40a4b4 Cr-Commit-Position: refs/heads/master@{#404184} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
