Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1972333002:
Use kEnableWebRtcHWH264Encoding flag when SW fallback is available (Closed)
|
Created:
4 years, 7 months ago by emircan Modified:
4 years, 7 months ago CC:
chromium-reviews, extensions-reviews_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, dzhioev+watch_chromium.org, achuith+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse kEnableWebRtcHWH264Encoding flag when SW fallback is available
HW H264 encoding was only enabled on extensions so far through
the use of kEnableWebRtcHWH264Encoding flag. This CL attaches
kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg
is available. As a result, HW H264 encoding would be enabled on
every supported platform where SW H264 fallback is also available.
BUG=611574
Committed: https://crrev.com/6468142875bd0d0b1064965e82c4b04747cac2fd
Cr-Commit-Position: refs/heads/master@{#393593}
Patch Set 1 #Patch Set 2 : Keep flag. #Messages
Total messages: 18 (9 generated)
Description was changed from ========== remove flag. BUG= ========== to ========== Remove kEnableWebRtcHWH264Encoding flag HW H264 encoding was only enabled on extensions so far. This CL removes the kEnableWebRtcHWH264Encoding flag that worked for this limitation. As a result, HW H264 encoding would be enabled on every available platform where SW H264 fallback is also available, which is checked via BUILDFLAG(RTC_USE_H264). BUG=611574 ==========
emircan@chromium.org changed reviewers: + niklase@chromium.org
emircan@chromium.org changed reviewers: + pbos@chromium.org
PTAL.
emircan@chromium.org changed reviewers: + hshi@chromium.org
Looking closer at the code I don't understand why HW 264 would not be exposed today when the SW flag is flipped. Let's discuss. On 2016/05/12 22:45:22, emircan wrote: > PTAL.
Description was changed from ========== Remove kEnableWebRtcHWH264Encoding flag HW H264 encoding was only enabled on extensions so far. This CL removes the kEnableWebRtcHWH264Encoding flag that worked for this limitation. As a result, HW H264 encoding would be enabled on every available platform where SW H264 fallback is also available, which is checked via BUILDFLAG(RTC_USE_H264). BUG=611574 ========== to ========== Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. BUG=611574 ==========
On 2016/05/13 15:44:14, Niklas Enbom wrote: > Looking closer at the code I don't understand why HW 264 would not be exposed > today when the SW flag is flipped. Let's discuss. > > On 2016/05/12 22:45:22, emircan wrote: > > PTAL. After offline description, I updated the description as well. PTAL.
lgtm On 2016/05/13 15:44:14, Niklas Enbom wrote: > Looking closer at the code I don't understand why HW 264 would not be exposed > today when the SW flag is flipped. Let's discuss. > > On 2016/05/12 22:45:22, emircan wrote: > > PTAL.
emircan@chromium.org changed reviewers: + mcasas@chromium.org
mcasas@ for RS review.
On 2016/05/13 17:34:24, emircan wrote: > mcasas@ for RS review. RS LGTM
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972333002/20001
Message was sent while issue was closed.
Description was changed from ========== Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. BUG=611574 ========== to ========== Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. BUG=611574 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. BUG=611574 ========== to ========== Use kEnableWebRtcHWH264Encoding flag when SW fallback is available HW H264 encoding was only enabled on extensions so far through the use of kEnableWebRtcHWH264Encoding flag. This CL attaches kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg is available. As a result, HW H264 encoding would be enabled on every supported platform where SW H264 fallback is also available. BUG=611574 Committed: https://crrev.com/6468142875bd0d0b1064965e82c4b04747cac2fd Cr-Commit-Position: refs/heads/master@{#393593} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6468142875bd0d0b1064965e82c4b04747cac2fd Cr-Commit-Position: refs/heads/master@{#393593} |
