Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2125083002:
Fix missing build dep when alternative_locale_resource_dep is used (Closed)
|
Created:
4 years, 5 months ago by agrieve Modified:
4 years, 5 months ago Reviewers:
michaelbai CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix missing build dep when alternative_locale_resource_dep is used
Broken by https://codereview.chromium.org/2109293003
BUG=620034, 626179
Committed: https://crrev.com/9101cda61c99a2e36033d46cf8c52d5c476b83f8
Cr-Commit-Position: refs/heads/master@{#404053}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
Description was changed from ========== Fix missing build dep when alternative_locale_resource_dep is used Broken by https://codereview.chromium.org/2109293003 BUG=620034 ========== to ========== Fix missing build dep when alternative_locale_resource_dep is used Broken by https://codereview.chromium.org/2109293003 BUG=620034 ==========
agrieve@chromium.org changed reviewers: + michaelbai@chromium.org
On 2016/07/06 17:29:10, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:michaelbai@chromium.org
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by agrieve@chromium.org
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix missing build dep when alternative_locale_resource_dep is used Broken by https://codereview.chromium.org/2109293003 BUG=620034 ========== to ========== Fix missing build dep when alternative_locale_resource_dep is used Broken by https://codereview.chromium.org/2109293003 BUG=620034,626179 ==========
Message was sent while issue was closed.
Description was changed from ========== Fix missing build dep when alternative_locale_resource_dep is used Broken by https://codereview.chromium.org/2109293003 BUG=620034,626179 ========== to ========== Fix missing build dep when alternative_locale_resource_dep is used Broken by https://codereview.chromium.org/2109293003 BUG=620034,626179 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Fix missing build dep when alternative_locale_resource_dep is used Broken by https://codereview.chromium.org/2109293003 BUG=620034,626179 ========== to ========== Fix missing build dep when alternative_locale_resource_dep is used Broken by https://codereview.chromium.org/2109293003 BUG=620034,626179 Committed: https://crrev.com/9101cda61c99a2e36033d46cf8c52d5c476b83f8 Cr-Commit-Position: refs/heads/master@{#404053} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9101cda61c99a2e36033d46cf8c52d5c476b83f8 Cr-Commit-Position: refs/heads/master@{#404053} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
