Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2124873002: Revert of Certificate Transparency DNS log client (Closed)

Created:
4 years, 5 months ago by jbroman
Modified:
4 years, 5 months ago
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, sdefresne+watchlist_chromium.org, Eran Messeri, droger+watchlist_chromium.org, blundell+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mock_dns_responses
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Certificate Transparency DNS log client (patchset #28 id:570001 of https://codereview.chromium.org/2066553002/ ) Reason for revert: Causing Win build failure: https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2184 Original issue's description: > Certificate Transparency DNS log client > > This can query CT logs over DNS, as defined by: > https://github.com/google/certificate-transparency-rfcs/blob/master/dns/draft-ct-over-dns.md > > This is required for obtaining audit proofs, which will allow Chrome to verify > that SCTs it receives are trustworthy and that logs are behaving correctly. > > BUG=612439 > > Committed: https://crrev.com/59b6ea2217dbc10400b6a9d433ad13c91bb6b7c2 > Cr-Commit-Position: refs/heads/master@{#403798} TBR=eranm@chromium.org,mmenke@chromium.org,jam@chromium.org,robpercival@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612439 Committed: https://crrev.com/fc4297bd21581ad0af3980ea79c9ff4f0fdfb064 Cr-Commit-Position: refs/heads/master@{#403800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1171 lines) Patch
M components/certificate_transparency.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M components/certificate_transparency/BUILD.gn View 4 chunks +0 lines, -5 lines 0 comments Download
M components/certificate_transparency/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/certificate_transparency/log_dns_client.h View 1 chunk +0 lines, -120 lines 0 comments Download
D components/certificate_transparency/log_dns_client.cc View 1 chunk +0 lines, -294 lines 0 comments Download
D components/certificate_transparency/log_dns_client_unittest.cc View 1 chunk +0 lines, -746 lines 0 comments Download
M components/components_tests.gyp View 4 chunks +4 lines, -1 line 0 comments Download
M net/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M net/net_common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbroman
Created Revert of Certificate Transparency DNS log client
4 years, 5 months ago (2016-07-05 17:40:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124873002/1
4 years, 5 months ago (2016-07-05 17:40:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 17:41:10 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 17:41:14 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fc4297bd21581ad0af3980ea79c9ff4f0fdfb064 Cr-Commit-Position: refs/heads/master@{#403800}
4 years, 5 months ago (2016-07-05 17:43:21 UTC) #7
Rob Percival
4 years, 5 months ago (2016-07-05 18:07:11 UTC) #8
Message was sent while issue was closed.
On 2016/07/05 17:43:21, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/fc4297bd21581ad0af3980ea79c9ff4f0fdfb064
> Cr-Commit-Position: refs/heads/master@{#403800}

FYI, the fix for the build failure is here:
https://codereview.chromium.org/2118383006.

Powered by Google App Engine
This is Rietveld 408576698